Skip to content

Commit dfe18c0

Browse files
committed
self-review: mark to revisit get_if chain
1 parent be9173c commit dfe18c0

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

llvm/lib/Frontend/HLSL/HLSLRootSignature.cpp

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -170,6 +170,12 @@ MDNode *MetadataBuilder::BuildRootSignature() {
170170
ElementMD = BuildDescriptorTableClause(*Clause);
171171
if (const auto &Table = std::get_if<DescriptorTable>(&Element))
172172
ElementMD = BuildDescriptorTable(*Table);
173+
174+
// FIXME(#126586): remove once all RootElemnt variants are handled in a
175+
// visit or otherwise
176+
assert(ElementMD != nullptr &&
177+
"Constructed an unhandled root element type.");
178+
173179
GeneratedMetadata.push_back(ElementMD);
174180
}
175181

0 commit comments

Comments
 (0)