@@ -748,8 +748,7 @@ BuiltinTypeDeclBuilder &BuiltinTypeDeclBuilder::addHandleMember(
748
748
// Adds default constructor to the resource class:
749
749
// Resource::Resource()
750
750
BuiltinTypeDeclBuilder &BuiltinTypeDeclBuilder::addDefaultHandleConstructor () {
751
- if (Record->isCompleteDefinition ())
752
- return *this ;
751
+ assert (!Record->isCompleteDefinition () && " record is already complete" );
753
752
754
753
using PH = BuiltinTypeMethodBuilder::PlaceHolder;
755
754
QualType HandleType = getResourceHandleField ()->getType ();
@@ -773,8 +772,7 @@ BuiltinTypeDeclBuilder &BuiltinTypeDeclBuilder::addDefaultHandleConstructor() {
773
772
// return tmp;
774
773
// }
775
774
BuiltinTypeDeclBuilder &BuiltinTypeDeclBuilder::addCreateFromBinding () {
776
- if (Record->isCompleteDefinition ())
777
- return *this ;
775
+ assert (!Record->isCompleteDefinition () && " record is already complete" );
778
776
779
777
using PH = BuiltinTypeMethodBuilder::PlaceHolder;
780
778
ASTContext &AST = SemaRef.getASTContext ();
@@ -811,8 +809,7 @@ BuiltinTypeDeclBuilder &BuiltinTypeDeclBuilder::addCreateFromBinding() {
811
809
// return tmp;
812
810
// }
813
811
BuiltinTypeDeclBuilder &BuiltinTypeDeclBuilder::addCreateFromImplicitBinding () {
814
- if (Record->isCompleteDefinition ())
815
- return *this ;
812
+ assert (!Record->isCompleteDefinition () && " record is already complete" );
816
813
817
814
using PH = BuiltinTypeMethodBuilder::PlaceHolder;
818
815
ASTContext &AST = SemaRef.getASTContext ();
@@ -838,8 +835,7 @@ BuiltinTypeDeclBuilder &BuiltinTypeDeclBuilder::addCreateFromImplicitBinding() {
838
835
}
839
836
840
837
BuiltinTypeDeclBuilder &BuiltinTypeDeclBuilder::addCopyConstructor () {
841
- if (Record->isCompleteDefinition ())
842
- return *this ;
838
+ assert (!Record->isCompleteDefinition () && " record is already complete" );
843
839
844
840
ASTContext &AST = SemaRef.getASTContext ();
845
841
QualType RecordType = AST.getCanonicalTagType (Record);
@@ -857,8 +853,7 @@ BuiltinTypeDeclBuilder &BuiltinTypeDeclBuilder::addCopyConstructor() {
857
853
}
858
854
859
855
BuiltinTypeDeclBuilder &BuiltinTypeDeclBuilder::addCopyAssignmentOperator () {
860
- if (Record->isCompleteDefinition ())
861
- return *this ;
856
+ assert (!Record->isCompleteDefinition () && " record is already complete" );
862
857
863
858
ASTContext &AST = SemaRef.getASTContext ();
864
859
QualType RecordType = AST.getCanonicalTagType (Record);
@@ -889,8 +884,7 @@ BuiltinTypeDeclBuilder &BuiltinTypeDeclBuilder::addArraySubscriptOperators() {
889
884
}
890
885
891
886
BuiltinTypeDeclBuilder &BuiltinTypeDeclBuilder::addLoadMethods () {
892
- if (Record->isCompleteDefinition ())
893
- return *this ;
887
+ assert (!Record->isCompleteDefinition () && " record is already complete" );
894
888
895
889
ASTContext &AST = Record->getASTContext ();
896
890
IdentifierInfo &II = AST.Idents .get (" Load" , tok::TokenKind::identifier);
@@ -931,12 +925,6 @@ BuiltinTypeDeclBuilder::getResourceAttrs() const {
931
925
return cast<HLSLAttributedResourceType>(HandleType)->getAttrs ();
932
926
}
933
927
934
- // BuiltinTypeDeclBuilder &BuiltinTypeDeclBuilder::startDefinition() {
935
- // assert(!Record->isCompleteDefinition() && "record is already complete");
936
- // Record->startDefinition();
937
- // return *this;
938
- // }
939
-
940
928
BuiltinTypeDeclBuilder &BuiltinTypeDeclBuilder::completeDefinition () {
941
929
assert (!Record->isCompleteDefinition () && " record is already complete" );
942
930
assert (Record->isBeingDefined () &&
0 commit comments