Skip to content

Conversation

@nibrunieAtSi5
Copy link

⚠️ this PR is still a work in progress, much work is still required before it is ready for review (help / feedback appreciated anyway).

This PR introduces support for a couple of vector crypto extensions under going the specification process at RVIA. Those extensions, Zvbc32e and Zvkgs, are undergoing a fast track process which is tracked by riscv/riscv-isa-manual#1306 and https://lf-riscv.atlassian.net/browse/RVS-1915.

What is done as part of this PR:

  • Adding Zvbc32e / Zvkgs support in extension declarations
  • Tablegen definitions for Zvbc32e
  • Adding RVV_REQ_Zvkgs definition
  • Adding Zvkgs instrinsics
  • Adding zvkgs + zvbc32e in RISC-V supported extensions (RISCVISAInfo.cpp)

* Adding Zvbc32e / Zvkgs support in extension declarations
* tablegen definitions for Zvbc32e
* Adding RVV_REQ_Zvkgs definition

[Zvbc32e/Zvkgs] introducing some changes required for fast track vector crypto extensions

more changes

Adding Zvkgs instrinsics

Adding zvkgs + zvbc32e in RISC-V supported extensions (RISCVISAInfo.cpp)

Adding zvkgs + zvbc32e in RISC-V supported extensions (RISCVISAInfo.cpp)
@github-actions
Copy link

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@nibrunieAtSi5
Copy link
Author

This PR is built has a porting to main of a branch which was originally created on top of llvm 18.1.8 tag (the top tag in riscv-gnu-toolchain when this effort was started). It looks like a few changes (including opcodes for the Zvkgs) did not make it properly to the port.

https://github.com/nibrunie/llvm-project/commits/riscv-zvbc32e-zvkgs-proto_from_llvmorg-18.1.8/

@nibrunieAtSi5
Copy link
Author

Actually, it looks like most of the support may have already been added as part of a80a90e

@nibrunieAtSi5 nibrunieAtSi5 changed the title [WIP][RISC-V] prototyping support for Zvbc32e and Zvkgs [WIP][RISC-V] prototyping intrinsic support for Zvbc32e and Zvkgs Apr 5, 2025
@topperc topperc requested review from 4vtomat, BeMg and topperc April 5, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants