[workflows] Update commit access request PR links #146169
Conversation
This PR updates the links used to show the PR contribution stats of the user requesting commit access to the LLVM project. The link previously would only show the PRs that were currently opened by the user because the `/pulls/<username>` endpoint automatically applies the `is:open` filter. The contribution guidelines suggest that the user should have at least 3 merged PRs to be considered for commit access so this seems like a relavant data point to add. We now show all PRs that the user has created and a separate link for the PRs that are merged.
boomanaiden154
left a comment
boomanaiden154
left a comment
There was a problem hiding this comment.
LGTM, but I agree with Jlalond@ comment. Please address that before landing this change.
Also, please let tstellar@ review this change before landing as he is the one who goes through these.
|
@tstellar please take a look when you get a chance, thanks! |
@tstellar please take a look when you get a chance, thanks! |
@tstellar please take a look when you get a chance, thanks! |
|
@dmpots Can we add is:merged to the query? That would be the most helpful, those are what actually count towards the requirements. |
@tstellar do you mean that we should only have the one link that shows the merged PRs and not the separate link for total vs. merged? It is currently adding the |
tstellar
left a comment
tstellar
left a comment
There was a problem hiding this comment.
I see what you are saying now, what you have here is fine.
This PR updates the links used to show the PR contribution stats of the user requesting commit access to the LLVM project. Previously we would only show the PRs that were currently opened by the user because the `/pulls/<username>` endpoint automatically applies the `is:open` filter. The contribution guidelines suggest that the user should have at least 3 merged PRs to be considered for commit access so this seems like a relevant data point to add. We now show all PRs that a user has created (not just the open ones) and a separate link for the PRs that are merged.
4 participants
This PR updates the links used to show the PR contribution stats of the user requesting commit access to the LLVM project. Previously we would only show the PRs that were currently opened by the user because the
/pulls/<username>endpoint automatically applies theis:openfilter.The contribution guidelines suggest that the user should have at least 3 merged PRs to be considered for commit access so this seems like a relevant data point to add.
We now show all PRs that a user has created (not just the open ones) and a separate link for the PRs that are merged.