Skip to content

Conversation

@Kristianerik
Copy link
Contributor

Fixes a typo in the include guard name in hlsl_compat_overloads.h

The incorrect line:
#define _HLSl_COMPAT_OVERLOADS_H_
has been corrected to:
#define _HLSL_COMPAT_OVERLOADS_H_

Fixes #164100

@github-actions
Copy link

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@llvmbot llvmbot added clang Clang issues not falling into any other category backend:X86 clang:headers Headers provided by Clang, e.g. for intrinsics labels Oct 22, 2025
@llvmbot
Copy link
Member

llvmbot commented Oct 22, 2025

@llvm/pr-subscribers-backend-x86

@llvm/pr-subscribers-clang

Author: Krisitan Erik Olsen (Kristianerik)

Changes

Fixes a typo in the include guard name in hlsl_compat_overloads.h

The incorrect line:
#define _HLSl_COMPAT_OVERLOADS_H_
has been corrected to:
#define _HLSL_COMPAT_OVERLOADS_H_

Fixes #164100


Full diff: https://github.com/llvm/llvm-project/pull/164540.diff

1 Files Affected:

  • (modified) clang/lib/Headers/hlsl/hlsl_compat_overloads.h (+1-1)
diff --git a/clang/lib/Headers/hlsl/hlsl_compat_overloads.h b/clang/lib/Headers/hlsl/hlsl_compat_overloads.h
index fe4277ed4a7d2..ee243abef6a41 100644
--- a/clang/lib/Headers/hlsl/hlsl_compat_overloads.h
+++ b/clang/lib/Headers/hlsl/hlsl_compat_overloads.h
@@ -7,7 +7,7 @@
 //===----------------------------------------------------------------------===//
 
 #ifndef _HLSL_COMPAT_OVERLOADS_H_
-#define _HLSl_COMPAT_OVERLOADS_H_
+#define _HLSL_COMPAT_OVERLOADS_H_
 
 namespace hlsl {
 

@Thibault-Monnier
Copy link
Contributor

@llvm-beanz @cor3ntin

@cor3ntin cor3ntin enabled auto-merge (squash) November 1, 2025 17:38
@cor3ntin cor3ntin merged commit 44df23a into llvm:main Nov 1, 2025
9 of 10 checks passed
@github-actions
Copy link

github-actions bot commented Nov 1, 2025

@Kristianerik Congratulations on having your first Pull Request (PR) merged into the LLVM Project!

Your changes will be combined with recent changes from other authors, then tested by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR.

Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues.

How to do this, and the rest of the post-merge process, is covered in detail here.

If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again.

If you don't get any reports, no action is required from you. Your changes are working as expected, well done!

DEBADRIBASAK pushed a commit to DEBADRIBASAK/llvm-project that referenced this pull request Nov 3, 2025
…#164540)

Fixes a typo in the include guard name in hlsl_compat_overloads.h 

The incorrect line:
`  #define _HLSl_COMPAT_OVERLOADS_H_`
has been corrected to:
`  #define _HLSL_COMPAT_OVERLOADS_H_`


Fixes llvm#164100
@Kristianerik Kristianerik deleted the fix-hlsl-include-guard branch November 4, 2025 20:26
ckoparkar pushed a commit to ckoparkar/llvm-project that referenced this pull request Nov 6, 2025
…#164540)

Fixes a typo in the include guard name in hlsl_compat_overloads.h 

The incorrect line:
`  #define _HLSl_COMPAT_OVERLOADS_H_`
has been corrected to:
`  #define _HLSL_COMPAT_OVERLOADS_H_`


Fixes llvm#164100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend:X86 clang:headers Headers provided by Clang, e.g. for intrinsics clang Clang issues not falling into any other category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Include guard typo in hlsl_compat_overloads.h

4 participants