-
Notifications
You must be signed in to change notification settings - Fork 15.2k
[CLANG][OpenMP] Add support for OpenMP6.0 transparent clause #166810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
kparzysz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay in reviewing.
The flang changes are actually not correct---what was there before was. The transparent clause takes an expression, not a constant.
|
Undo all changes in flang/*, ClauseT.h, and restore the "isValueOptional" in OMP.td. That should make it ok. |
Thanks! will try that. |
🐧 Linux x64 Test Results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Edit: Please wait for Alexey's review.
Thanks! |
|
Do we have support for this in runtime library? If not, this definitely requires initial support in runtime at first |
No. Should the runtime change be a preliminary PR to this one? I am assuming that a |
|
Runtime changes proposed here: #168873 |
Add basic parsing and semantic support for
transparentclause fortaskandtaskloopdirectives described inSection 17.9.6of https://www.openmp.org/wp-content/uploads/OpenMP-API-Specification-6-0.pdf .