Skip to content

Conversation

@zahiraam
Copy link
Contributor

@zahiraam zahiraam commented Nov 6, 2025

Add basic parsing and semantic support for transparent clause for task andtaskloop directives described in Section 17.9.6 of https://www.openmp.org/wp-content/uploads/OpenMP-API-Specification-6-0.pdf .

@github-actions
Copy link

github-actions bot commented Nov 6, 2025

✅ With the latest revision this PR passed the C/C++ code formatter.

@zahiraam

This comment was marked as outdated.

@Meinersbur

This comment was marked as outdated.

@zahiraam

This comment was marked as outdated.

@zahiraam

This comment was marked as outdated.

@zahiraam

This comment was marked as outdated.

@zahiraam zahiraam marked this pull request as ready for review November 17, 2025 20:37
@zahiraam

This comment was marked as outdated.

@Meinersbur

This comment was marked as outdated.

Copy link
Contributor

@kparzysz kparzysz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay in reviewing.

The flang changes are actually not correct---what was there before was. The transparent clause takes an expression, not a constant.

@kparzysz
Copy link
Contributor

Undo all changes in flang/*, ClauseT.h, and restore the "isValueOptional" in OMP.td. That should make it ok.

@zahiraam
Copy link
Contributor Author

Undo all changes in flang/*, ClauseT.h, and restore the "isValueOptional" in OMP.td. That should make it ok.

Thanks! will try that.

@github-actions
Copy link

🐧 Linux x64 Test Results

  • 192823 tests passed
  • 6177 tests skipped

Copy link
Contributor

@kparzysz kparzysz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Edit: Please wait for Alexey's review.

@zahiraam
Copy link
Contributor Author

LGTM, thanks!

Edit: Please wait for Alexey's review.

Thanks!

@alexey-bataev
Copy link
Member

Do we have support for this in runtime library? If not, this definitely requires initial support in runtime at first

@zahiraam
Copy link
Contributor Author

Do we have support for this in runtime library? If not, this definitely requires initial support in runtime at first

No. Should the runtime change be a preliminary PR to this one? I am assuming that a Transparent flag needs to be added to kmp_tasking_flags.

@zahiraam
Copy link
Contributor Author

Runtime changes proposed here: #168873

@zahiraam
Copy link
Contributor Author

Runtime changes proposed here: #168873

@alexey-bataev Would adding the flag in #168873 be enough for this PR to be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants