[offload][lit] Fix compilation of two offload tests

[sarnex]

These are C tests, not C++, so no function parameters means unspecified number of parameters, not void.

These compile fine on the current tested offload targets because an error is only thrown if the calling convention doesn't support variadic arguments, which they happen to.

When compiling this test for other targets that do not support variadic arguments, we get an error, which does not seem intentional.

Just add void to the parameter list.

[llvmbot]

@llvm/pr-subscribers-offload

Author: Nick Sarnie (sarnex)

Changes

These are C tests, not C++, so no function parameters means unspecified number of parameters, not void.

These compile fine on the current tested offload targets because an error is only thrown if the calling convention doesn't support variadic arguments, which they happen to.

When compiling this test for other targets that do not support variadic arguments, we get an error, which does not seem intentional.

Just add void to the parameter list.

---

Full diff: https://github.com/llvm/llvm-project/pull/169399.diff

2 Files Affected:

• (modified) offload/test/offloading/shared_lib_fp_mapping.c (+1-1)
• (modified) offload/test/offloading/static_linking.c (+1-1)

diff --git a/offload/test/offloading/shared_lib_fp_mapping.c b/offload/test/offloading/shared_lib_fp_mapping.c
index c6203443eee18..0e1fed4d0baf8 100644
--- a/offload/test/offloading/shared_lib_fp_mapping.c
+++ b/offload/test/offloading/shared_lib_fp_mapping.c
@@ -7,7 +7,7 @@
 
 #include <stdio.h>
 
-extern int func(); // Provided in liba.so, returns 42
+extern int func(void); // Provided in liba.so, returns 42
 typedef int (*fp_t)();
 
 int main() {
diff --git a/offload/test/offloading/static_linking.c b/offload/test/offloading/static_linking.c
index 7be95a10ffcd6..273109e10c09e 100644
--- a/offload/test/offloading/static_linking.c
+++ b/offload/test/offloading/static_linking.c
@@ -14,7 +14,7 @@ int foo() {
 }
 #else
 #include <stdio.h>
-int foo();
+int foo(void);
 
 int main() {
   int x = foo();

[kevinsala]

Same for the typedef?

[sarnex]

I was using SPIR-V to repro the issue and it compiled successfully with just the func change.

[kevinsala]

I think you need the void in the typedef too, otherwise it's a type mismatch. Most compilers will accept it. Clang just reports a warning.

[sarnex]

Added in latest commit, thanks!

[kevinsala]

LGTM