github-upload-release.py: add requirements and lock files for installing dependencies #169461
Conversation
|
cc: @boomanaiden154 |
boomanaiden154
left a comment
boomanaiden154
left a comment
There was a problem hiding this comment.
This is not how we manage dependencies. This needs to go in a requirements.txt along with a generated lockfile, or piggy back off something else.
nightlark
force-pushed
the
add-pep723-requirements-to-permissions-check
branch
from
3b7e039 to
edb4263
Compare
nightlark
changed the title
I changed it to requirements.txt and a generated lockfile for this PR, however I think it would be good to consider adding the inline script metadata to make it obvious to someone looking at the script what dependencies it needs installed are (and that follows the script if it ever gets moved around in the repository. |
nightlark
changed the title
nightlark
changed the title
nightlark
force-pushed
the
add-pep723-requirements-to-permissions-check
branch
from
edb4263 to
51793ed
Compare
You can add a docstring that references the |
…ing dependencies Signed-off-by: Ryan Mast <[email protected]>
nightlark
force-pushed
the
add-pep723-requirements-to-permissions-check
branch
from
51793ed to
fba3dac
Compare
boomanaiden154
left a comment
boomanaiden154
left a comment
There was a problem hiding this comment.
LGTM. Might be good at some point to look at consolidating all of the requirements files, but we can leave that for the future.
…ing dependencies (llvm#169461) Adds requirements.txt and lock files for installing dependencies for github-upload-release.py script. Signed-off-by: Ryan Mast <[email protected]>
…ing dependencies (llvm#169461) Adds requirements.txt and lock files for installing dependencies for github-upload-release.py script. Signed-off-by: Ryan Mast <[email protected]>
2 participants
Adds requirements.txt and lock files for installing dependencies for github-upload-release.py script.