hipcc/ld.lld unable to link separable compilation when dynamic librar… #169551

david-salinas · 2025-11-25T19:05:15Z

…y is fully specified

llvmbot · 2025-11-25T19:05:46Z

@llvm/pr-subscribers-clang-driver

@llvm/pr-subscribers-clang

Author: David Salinas (david-salinas)

Changes

…y is fully specified

Full diff: https://github.com/llvm/llvm-project/pull/169551.diff

1 Files Affected:

(modified) clang/lib/Driver/ToolChains/HIPUtility.cpp (+4-2)

diff --git a/clang/lib/Driver/ToolChains/HIPUtility.cpp b/clang/lib/Driver/ToolChains/HIPUtility.cpp
index 1af2ae6470f1e..76d1fb2863a88 100644
--- a/clang/lib/Driver/ToolChains/HIPUtility.cpp
+++ b/clang/lib/Driver/ToolChains/HIPUtility.cpp
@@ -241,15 +241,17 @@ class HIPUndefinedFatBinSymbols {
 
       bool isUndefined =
           FlagOrErr.get() & llvm::object::SymbolRef::SF_Undefined;
+       bool isHidden =
+          FlagOrErr.get() & llvm::object::SymbolRef::SF_Hidden;
       bool isFatBinSymbol = Name.starts_with(FatBinPrefix);
       bool isGPUBinHandleSymbol = Name.starts_with(GPUBinHandlePrefix);
 
       // Handling for defined symbols
       if (!isUndefined) {
-        if (isFatBinSymbol) {
+        if ((isFatBinSymbol) && (!isHidden) {
           DefinedFatBinSymbols.insert(Name.str());
           FatBinSymbols.erase(Name.str());
-        } else if (isGPUBinHandleSymbol) {
+        } else if ((isGPUBinHandleSymbol) && (!isHidden) {
           DefinedGPUBinHandleSymbols.insert(Name.str());
           GPUBinHandleSymbols.erase(Name.str());
         }

github-actions · 2025-11-25T19:07:09Z

✅ With the latest revision this PR passed the C/C++ code formatter.

…y is fully specified

clang/lib/Driver/ToolChains/HIPUtility.cpp

Co-authored-by: Omri Mor <[email protected]>

move (!isHidden) to upper level if-statement.

github-actions · 2025-11-27T00:57:31Z

🐧 Linux x64 Test Results

84769 tests passed
1119 tests skipped
1 test failed

Failed Tests

(click on a test name to see its output)

Clang

Clang.Driver/hip-partial-link.hip

Exit Code: 1

Command Output (stdout):
--
# RUN: at line 3
/home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/clang -x hip --target=x86_64-unknown-linux-gnu --no-offload-new-driver    --offload-arch=gfx906 -c -nostdinc -nogpuinc -nohipwrapperinc    -nogpulib -fgpu-rdc -I/home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/Driver/Inputs /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/Driver/hip-partial-link.hip -o /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/Driver/Output/hip-partial-link.hip.tmp.1.o
# executed command: /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/clang -x hip --target=x86_64-unknown-linux-gnu --no-offload-new-driver --offload-arch=gfx906 -c -nostdinc -nogpuinc -nohipwrapperinc -nogpulib -fgpu-rdc -I/home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/Driver/Inputs /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/Driver/hip-partial-link.hip -o /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/Driver/Output/hip-partial-link.hip.tmp.1.o
# .---command stderr------------
# | clang: warning: argument unused during compilation: '-nohipwrapperinc' [-Wunused-command-line-argument]
# `-----------------------------
# RUN: at line 7
/home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/clang -x hip --target=x86_64-unknown-linux-gnu -DLIB --no-offload-new-driver    --offload-arch=gfx906 -c -nostdinc -nogpuinc -nohipwrapperinc    -nogpulib -fgpu-rdc -I/home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/Driver/Inputs /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/Driver/hip-partial-link.hip -o /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/Driver/Output/hip-partial-link.hip.tmp.2.o
# executed command: /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/clang -x hip --target=x86_64-unknown-linux-gnu -DLIB --no-offload-new-driver --offload-arch=gfx906 -c -nostdinc -nogpuinc -nohipwrapperinc -nogpulib -fgpu-rdc -I/home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/Driver/Inputs /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/Driver/hip-partial-link.hip -o /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/Driver/Output/hip-partial-link.hip.tmp.2.o
# .---command stderr------------
# | clang: warning: argument unused during compilation: '-nohipwrapperinc' [-Wunused-command-line-argument]
# `-----------------------------
# RUN: at line 11
/home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/clang -x hip --target=x86_64-unknown-linux-gnu -DMAIN --no-offload-new-driver    --offload-arch=gfx906 -c -nostdinc -nogpuinc -nohipwrapperinc    -nogpulib -fgpu-rdc -I/home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/Driver/Inputs /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/Driver/hip-partial-link.hip -o /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/Driver/Output/hip-partial-link.hip.tmp.main.o
# executed command: /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/clang -x hip --target=x86_64-unknown-linux-gnu -DMAIN --no-offload-new-driver --offload-arch=gfx906 -c -nostdinc -nogpuinc -nohipwrapperinc -nogpulib -fgpu-rdc -I/home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/Driver/Inputs /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/Driver/hip-partial-link.hip -o /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/Driver/Output/hip-partial-link.hip.tmp.main.o
# .---command stderr------------
# | clang: warning: argument unused during compilation: '-nohipwrapperinc' [-Wunused-command-line-argument]
# `-----------------------------
# RUN: at line 15
llvm-nm  /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/Driver/Output/hip-partial-link.hip.tmp.1.o | /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/FileCheck -check-prefix=OBJ1 /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/Driver/hip-partial-link.hip
# executed command: llvm-nm /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/Driver/Output/hip-partial-link.hip.tmp.1.o
# note: command had no output on stdout or stderr
# executed command: /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/FileCheck -check-prefix=OBJ1 /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/Driver/hip-partial-link.hip
# note: command had no output on stdout or stderr
# RUN: at line 20
llvm-nm  /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/Driver/Output/hip-partial-link.hip.tmp.2.o | /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/FileCheck -check-prefix=OBJ2 /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/Driver/hip-partial-link.hip
# executed command: llvm-nm /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/Driver/Output/hip-partial-link.hip.tmp.2.o
# note: command had no output on stdout or stderr
# executed command: /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/FileCheck -check-prefix=OBJ2 /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/Driver/hip-partial-link.hip
# note: command had no output on stdout or stderr
# RUN: at line 27
/home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/clang -v --target=x86_64-unknown-linux-gnu --no-offload-new-driver    --hip-link -fgpu-rdc --offload-arch=gfx906    -r -fuse-ld=lld -nostdlib /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/Driver/Output/hip-partial-link.hip.tmp.1.o /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/Driver/Output/hip-partial-link.hip.tmp.2.o -o /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/Driver/Output/hip-partial-link.hip.tmp.lib.o    2>&1 | /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/FileCheck -check-prefix=LD-R /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/Driver/hip-partial-link.hip
# executed command: /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/clang -v --target=x86_64-unknown-linux-gnu --no-offload-new-driver --hip-link -fgpu-rdc --offload-arch=gfx906 -r -fuse-ld=lld -nostdlib /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/Driver/Output/hip-partial-link.hip.tmp.1.o /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/Driver/Output/hip-partial-link.hip.tmp.2.o -o /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/Driver/Output/hip-partial-link.hip.tmp.lib.o
# note: command had no output on stdout or stderr
# executed command: /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/FileCheck -check-prefix=LD-R /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/Driver/hip-partial-link.hip
# note: command had no output on stdout or stderr
# RUN: at line 41
llvm-nm  /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/Driver/Output/hip-partial-link.hip.tmp.lib.o | /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/FileCheck -check-prefix=OBJ /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/Driver/hip-partial-link.hip
# executed command: llvm-nm /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/Driver/Output/hip-partial-link.hip.tmp.lib.o
# note: command had no output on stdout or stderr
# executed command: /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/FileCheck -check-prefix=OBJ /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/Driver/hip-partial-link.hip
# note: command had no output on stdout or stderr
# RUN: at line 49
/home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/clang -v --target=x86_64-unknown-linux-gnu --no-offload-new-driver    --hip-link -fgpu-rdc --offload-arch=gfx906    -fuse-ld=lld -nostdlib -r /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/Driver/Output/hip-partial-link.hip.tmp.main.o /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/Driver/Output/hip-partial-link.hip.tmp.lib.o -o /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/Driver/Output/hip-partial-link.hip.tmp.final.o    2>&1 | /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/FileCheck -check-prefix=LINK-O /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/Driver/hip-partial-link.hip
# executed command: /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/clang -v --target=x86_64-unknown-linux-gnu --no-offload-new-driver --hip-link -fgpu-rdc --offload-arch=gfx906 -fuse-ld=lld -nostdlib -r /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/Driver/Output/hip-partial-link.hip.tmp.main.o /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/Driver/Output/hip-partial-link.hip.tmp.lib.o -o /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/Driver/Output/hip-partial-link.hip.tmp.final.o
# note: command had no output on stdout or stderr
# error: command failed with exit status: 1
# executed command: /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/FileCheck -check-prefix=LINK-O /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/Driver/hip-partial-link.hip
# .---command stderr------------
# | /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/Driver/hip-partial-link.hip:53:16: error: LINK-O-NOT: excluded string found in input
# | // LINK-O-NOT: Found undefined HIP {{.*}}symbol
# |                ^
# | <stdin>:11:1: note: found here
# | Found undefined HIP gpubin handle symbol: __hip_gpubin_handle_40d633bfc93cab51
# | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# | 
# | Input file: <stdin>
# | Check file: /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/Driver/hip-partial-link.hip
# | 
# | -dump-input=help explains the following input dump.
# | 
# | Input was:
# | <<<<<<
# |         .
# |         .
# |         .
# |         6: Found candidate GCC installation: /usr/lib/gcc/x86_64-linux-gnu/11 
# |         7: Found candidate GCC installation: /usr/lib/gcc/x86_64-linux-gnu/13 
# |         8: Selected GCC installation: /usr/lib/gcc/x86_64-linux-gnu/13 
# |         9: Candidate multilib: .;@m64 
# |        10: Selected multilib: .;@m64 
# |        11: Found undefined HIP gpubin handle symbol: __hip_gpubin_handle_40d633bfc93cab51 
# | not:53     !~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~                                        error: no match expected
# |        12: Found undefined HIP gpubin handle symbol: __hip_gpubin_handle_823bf80253f53d10 
# |        13:  "/home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/clang-offload-bundler" -type=o -targets=host-x86_64-unknown-linux-gnu,hip-amdgcn-amd-amdhsa-unknown-gfx906 -input=/home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/Driver/Output/hip-partial-link.hip.tmp.main.o -output=/tmp/lit-tmp-l2rx1v86/hip-partial-link-8b009e.o -output=/tmp/lit-tmp-l2rx1v86/hip-partial-link-gfx906-c1485c.o -unbundle -allow-missing-bundles -verbose 
# |        14: Uncompressed bundle. 
# |        15:  "/home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/clang-offload-bundler" -type=o -targets=host-x86_64-unknown-linux-gnu,hip-amdgcn-amd-amdhsa-unknown-gfx906 -input=/home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/Driver/Output/hip-partial-link.hip.tmp.lib.o -output=/tmp/lit-tmp-l2rx1v86/hip-partial-link-cfc65e.o -output=/tmp/lit-tmp-l2rx1v86/hip-partial-link-gfx906-9e8cd8.o -unbundle -allow-missing-bundles -verbose 
# |        16: Uncompressed bundle. 
# |         .
# |         .
# |         .
# | >>>>>>
# `-----------------------------
# error: command failed with exit status: 1

--

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the infrastructure label.

yxsamliu · 2025-11-27T14:00:06Z

🐧 Linux x64 Test Results

84769 tests passed
1119 tests skipped
1 test failed

Failed Tests

(click on a test name to see its output)

Clang

Clang.Driver/hip-partial-link.hip

Exit Code: 1

Command Output (stdout):
--
# RUN: at line 3
/home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/clang -x hip --target=x86_64-unknown-linux-gnu --no-offload-new-driver    --offload-arch=gfx906 -c -nostdinc -nogpuinc -nohipwrapperinc    -nogpulib -fgpu-rdc -I/home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/Driver/Inputs /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/Driver/hip-partial-link.hip -o /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/Driver/Output/hip-partial-link.hip.tmp.1.o
# executed command: /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/clang -x hip --target=x86_64-unknown-linux-gnu --no-offload-new-driver --offload-arch=gfx906 -c -nostdinc -nogpuinc -nohipwrapperinc -nogpulib -fgpu-rdc -I/home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/Driver/Inputs /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/Driver/hip-partial-link.hip -o /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/Driver/Output/hip-partial-link.hip.tmp.1.o
# .---command stderr------------
# | clang: warning: argument unused during compilation: '-nohipwrapperinc' [-Wunused-command-line-argument]
# `-----------------------------
# RUN: at line 7
/home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/clang -x hip --target=x86_64-unknown-linux-gnu -DLIB --no-offload-new-driver    --offload-arch=gfx906 -c -nostdinc -nogpuinc -nohipwrapperinc    -nogpulib -fgpu-rdc -I/home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/Driver/Inputs /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/Driver/hip-partial-link.hip -o /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/Driver/Output/hip-partial-link.hip.tmp.2.o
# executed command: /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/clang -x hip --target=x86_64-unknown-linux-gnu -DLIB --no-offload-new-driver --offload-arch=gfx906 -c -nostdinc -nogpuinc -nohipwrapperinc -nogpulib -fgpu-rdc -I/home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/Driver/Inputs /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/Driver/hip-partial-link.hip -o /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/Driver/Output/hip-partial-link.hip.tmp.2.o
# .---command stderr------------
# | clang: warning: argument unused during compilation: '-nohipwrapperinc' [-Wunused-command-line-argument]
# `-----------------------------
# RUN: at line 11
/home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/clang -x hip --target=x86_64-unknown-linux-gnu -DMAIN --no-offload-new-driver    --offload-arch=gfx906 -c -nostdinc -nogpuinc -nohipwrapperinc    -nogpulib -fgpu-rdc -I/home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/Driver/Inputs /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/Driver/hip-partial-link.hip -o /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/Driver/Output/hip-partial-link.hip.tmp.main.o
# executed command: /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/clang -x hip --target=x86_64-unknown-linux-gnu -DMAIN --no-offload-new-driver --offload-arch=gfx906 -c -nostdinc -nogpuinc -nohipwrapperinc -nogpulib -fgpu-rdc -I/home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/Driver/Inputs /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/Driver/hip-partial-link.hip -o /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/Driver/Output/hip-partial-link.hip.tmp.main.o
# .---command stderr------------
# | clang: warning: argument unused during compilation: '-nohipwrapperinc' [-Wunused-command-line-argument]
# `-----------------------------
# RUN: at line 15
llvm-nm  /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/Driver/Output/hip-partial-link.hip.tmp.1.o | /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/FileCheck -check-prefix=OBJ1 /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/Driver/hip-partial-link.hip
# executed command: llvm-nm /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/Driver/Output/hip-partial-link.hip.tmp.1.o
# note: command had no output on stdout or stderr
# executed command: /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/FileCheck -check-prefix=OBJ1 /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/Driver/hip-partial-link.hip
# note: command had no output on stdout or stderr
# RUN: at line 20
llvm-nm  /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/Driver/Output/hip-partial-link.hip.tmp.2.o | /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/FileCheck -check-prefix=OBJ2 /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/Driver/hip-partial-link.hip
# executed command: llvm-nm /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/Driver/Output/hip-partial-link.hip.tmp.2.o
# note: command had no output on stdout or stderr
# executed command: /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/FileCheck -check-prefix=OBJ2 /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/Driver/hip-partial-link.hip
# note: command had no output on stdout or stderr
# RUN: at line 27
/home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/clang -v --target=x86_64-unknown-linux-gnu --no-offload-new-driver    --hip-link -fgpu-rdc --offload-arch=gfx906    -r -fuse-ld=lld -nostdlib /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/Driver/Output/hip-partial-link.hip.tmp.1.o /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/Driver/Output/hip-partial-link.hip.tmp.2.o -o /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/Driver/Output/hip-partial-link.hip.tmp.lib.o    2>&1 | /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/FileCheck -check-prefix=LD-R /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/Driver/hip-partial-link.hip
# executed command: /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/clang -v --target=x86_64-unknown-linux-gnu --no-offload-new-driver --hip-link -fgpu-rdc --offload-arch=gfx906 -r -fuse-ld=lld -nostdlib /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/Driver/Output/hip-partial-link.hip.tmp.1.o /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/Driver/Output/hip-partial-link.hip.tmp.2.o -o /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/Driver/Output/hip-partial-link.hip.tmp.lib.o
# note: command had no output on stdout or stderr
# executed command: /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/FileCheck -check-prefix=LD-R /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/Driver/hip-partial-link.hip
# note: command had no output on stdout or stderr
# RUN: at line 41
llvm-nm  /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/Driver/Output/hip-partial-link.hip.tmp.lib.o | /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/FileCheck -check-prefix=OBJ /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/Driver/hip-partial-link.hip
# executed command: llvm-nm /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/Driver/Output/hip-partial-link.hip.tmp.lib.o
# note: command had no output on stdout or stderr
# executed command: /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/FileCheck -check-prefix=OBJ /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/Driver/hip-partial-link.hip
# note: command had no output on stdout or stderr
# RUN: at line 49
/home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/clang -v --target=x86_64-unknown-linux-gnu --no-offload-new-driver    --hip-link -fgpu-rdc --offload-arch=gfx906    -fuse-ld=lld -nostdlib -r /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/Driver/Output/hip-partial-link.hip.tmp.main.o /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/Driver/Output/hip-partial-link.hip.tmp.lib.o -o /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/Driver/Output/hip-partial-link.hip.tmp.final.o    2>&1 | /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/FileCheck -check-prefix=LINK-O /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/Driver/hip-partial-link.hip
# executed command: /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/clang -v --target=x86_64-unknown-linux-gnu --no-offload-new-driver --hip-link -fgpu-rdc --offload-arch=gfx906 -fuse-ld=lld -nostdlib -r /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/Driver/Output/hip-partial-link.hip.tmp.main.o /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/Driver/Output/hip-partial-link.hip.tmp.lib.o -o /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/Driver/Output/hip-partial-link.hip.tmp.final.o
# note: command had no output on stdout or stderr
# error: command failed with exit status: 1
# executed command: /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/FileCheck -check-prefix=LINK-O /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/Driver/hip-partial-link.hip
# .---command stderr------------
# | /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/Driver/hip-partial-link.hip:53:16: error: LINK-O-NOT: excluded string found in input
# | // LINK-O-NOT: Found undefined HIP {{.*}}symbol
# |                ^
# | <stdin>:11:1: note: found here
# | Found undefined HIP gpubin handle symbol: __hip_gpubin_handle_40d633bfc93cab51
# | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# | 
# | Input file: <stdin>
# | Check file: /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/Driver/hip-partial-link.hip
# | 
# | -dump-input=help explains the following input dump.
# | 
# | Input was:
# | <<<<<<
# |         .
# |         .
# |         .
# |         6: Found candidate GCC installation: /usr/lib/gcc/x86_64-linux-gnu/11 
# |         7: Found candidate GCC installation: /usr/lib/gcc/x86_64-linux-gnu/13 
# |         8: Selected GCC installation: /usr/lib/gcc/x86_64-linux-gnu/13 
# |         9: Candidate multilib: .;@m64 
# |        10: Selected multilib: .;@m64 
# |        11: Found undefined HIP gpubin handle symbol: __hip_gpubin_handle_40d633bfc93cab51 
# | not:53     !~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~                                        error: no match expected
# |        12: Found undefined HIP gpubin handle symbol: __hip_gpubin_handle_823bf80253f53d10 
# |        13:  "/home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/clang-offload-bundler" -type=o -targets=host-x86_64-unknown-linux-gnu,hip-amdgcn-amd-amdhsa-unknown-gfx906 -input=/home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/Driver/Output/hip-partial-link.hip.tmp.main.o -output=/tmp/lit-tmp-l2rx1v86/hip-partial-link-8b009e.o -output=/tmp/lit-tmp-l2rx1v86/hip-partial-link-gfx906-c1485c.o -unbundle -allow-missing-bundles -verbose 
# |        14: Uncompressed bundle. 
# |        15:  "/home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/clang-offload-bundler" -type=o -targets=host-x86_64-unknown-linux-gnu,hip-amdgcn-amd-amdhsa-unknown-gfx906 -input=/home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/clang/test/Driver/Output/hip-partial-link.hip.tmp.lib.o -output=/tmp/lit-tmp-l2rx1v86/hip-partial-link-cfc65e.o -output=/tmp/lit-tmp-l2rx1v86/hip-partial-link-gfx906-9e8cd8.o -unbundle -allow-missing-bundles -verbose 
# |        16: Uncompressed bundle. 
# |         .
# |         .
# |         .
# | >>>>>>
# `-----------------------------
# error: command failed with exit status: 1

--

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the infrastructure label.

Is the failure related to this change?

llvmbot added clang Clang issues not falling into any other category clang:driver 'clang' and 'clang++' user-facing binaries. Not 'clang-cl' labels Nov 25, 2025

david-salinas force-pushed the hip_linking_hidden_undef_syms branch from cf846bc to 3766397 Compare November 25, 2025 19:07

hipcc/ld.lld unable to link separable compilation when dynamic librar…

6bfbc08

…y is fully specified

david-salinas force-pushed the hip_linking_hidden_undef_syms branch from 3766397 to 6bfbc08 Compare November 25, 2025 19:14

david-salinas requested a review from yxsamliu November 25, 2025 19:26

yxsamliu reviewed Nov 26, 2025

View reviewed changes

clang/lib/Driver/ToolChains/HIPUtility.cpp Outdated Show resolved Hide resolved

remove redundant parenthesis

a49c285

omor1 reviewed Nov 27, 2025

View reviewed changes

clang/lib/Driver/ToolChains/HIPUtility.cpp Outdated Show resolved Hide resolved

david-salinas requested a review from omor1 November 27, 2025 00:26

david-salinas and others added 2 commits November 26, 2025 19:33

Apply suggestion from @omor1

3ffbf84

Co-authored-by: Omri Mor <[email protected]>

Update HIPUtility.cpp

3fe8f32

move (!isHidden) to upper level if-statement.

david-salinas requested a review from yxsamliu November 27, 2025 00:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

hipcc/ld.lld unable to link separable compilation when dynamic librar… #169551

hipcc/ld.lld unable to link separable compilation when dynamic librar… #169551

Uh oh!

david-salinas commented Nov 25, 2025

Uh oh!

llvmbot commented Nov 25, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Nov 25, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Nov 27, 2025

Uh oh!

yxsamliu commented Nov 27, 2025

🐧 Linux x64 Test Results

Failed Tests

Clang

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

hipcc/ld.lld unable to link separable compilation when dynamic librar… #169551

Are you sure you want to change the base?

hipcc/ld.lld unable to link separable compilation when dynamic librar… #169551

Uh oh!

Conversation

david-salinas commented Nov 25, 2025

Uh oh!

llvmbot commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Nov 27, 2025

🐧 Linux x64 Test Results

Failed Tests

Clang

Uh oh!

yxsamliu commented Nov 27, 2025

🐧 Linux x64 Test Results

Failed Tests

Clang

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

llvmbot commented Nov 25, 2025 •

edited

Loading

github-actions bot commented Nov 25, 2025 •

edited

Loading