Skip to content

hipcc/ld.lld unable to link separable compilation when dynamic librar… #169551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+2 −1
Open

hipcc/ld.lld unable to link separable compilation when dynamic librar… #169551

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6bfbc08
hipcc/ld.lld unable to link separable compilation when dynamic librar…
david-salinas Nov 25, 2025
a49c285
remove redundant parenthesis
david-salinas Nov 26, 2025
3ffbf84
Apply suggestion from @omor1
david-salinas Nov 27, 2025
3fe8f32
Update HIPUtility.cpp
david-salinas Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions clang/lib/Driver/ToolChains/HIPUtility.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,15 +241,16 @@ class HIPUndefinedFatBinSymbols {

bool isUndefined =
FlagOrErr.get() & llvm::object::SymbolRef::SF_Undefined;
bool isHidden = FlagOrErr.get() & llvm::object::SymbolRef::SF_Hidden;
bool isFatBinSymbol = Name.starts_with(FatBinPrefix);
bool isGPUBinHandleSymbol = Name.starts_with(GPUBinHandlePrefix);

// Handling for defined symbols
if (!isUndefined) {
if (isFatBinSymbol) {
if (isFatBinSymbol && !isHidden) {
DefinedFatBinSymbols.insert(Name.str());
FatBinSymbols.erase(Name.str());
} else if (isGPUBinHandleSymbol) {
} else if (isGPUBinHandleSymbol && !isHidden) {
DefinedGPUBinHandleSymbols.insert(Name.str());
GPUBinHandleSymbols.erase(Name.str());
}
Expand Down