-
Notifications
You must be signed in to change notification settings - Fork 15.4k
[AArch64] Lower alias mask to a whilewr #100769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 12 commits
c943b04
54129dc
a667dcd
9899a41
5f739bd
e69f3be
653d6d2
487ff3c
ab22dd1
0c378a3
f114dc7
bbcb935
6c700e7
207c3bc
82da889
4959eba
2072294
46602d8
c30aa10
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1523,6 +1523,7 @@ AArch64TargetLowering::AArch64TargetLowering(const TargetMachine &TM, | |
| setOperationAction(ISD::VECREDUCE_AND, VT, Custom); | ||
| setOperationAction(ISD::VECREDUCE_OR, VT, Custom); | ||
| setOperationAction(ISD::VECREDUCE_XOR, VT, Custom); | ||
| setOperationAction(ISD::OR, VT, Custom); | ||
|
|
||
| setOperationAction(ISD::SELECT_CC, VT, Expand); | ||
| setOperationAction(ISD::INSERT_VECTOR_ELT, VT, Custom); | ||
|
|
@@ -13782,8 +13783,90 @@ static SDValue tryLowerToSLI(SDNode *N, SelectionDAG &DAG) { | |
| return ResultSLI; | ||
| } | ||
|
|
||
| /// Try to lower the construction of a pointer alias mask to a WHILEWR. | ||
| /// The mask's enabled lanes represent the elements that will not overlap across | ||
| /// one loop iteration. This tries to match: | ||
| /// or (splat (setcc_lt (sub ptrA, ptrB), -(element_size - 1))), | ||
| /// (get_active_lane_mask 0, (div (sub ptrA, ptrB), element_size)) | ||
| SDValue tryWhileWRFromOR(SDValue Op, SelectionDAG &DAG) { | ||
| if (!DAG.getSubtarget<AArch64Subtarget>().hasSVE2()) | ||
| return SDValue(); | ||
| SDValue LaneMask = Op.getOperand(0); | ||
| SDValue Splat = Op.getOperand(1); | ||
davemgreen marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| if (Splat.getOpcode() != ISD::SPLAT_VECTOR) | ||
| std::swap(LaneMask, Splat); | ||
davemgreen marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| if (LaneMask.getOpcode() != ISD::INTRINSIC_WO_CHAIN || | ||
| LaneMask.getConstantOperandVal(0) != Intrinsic::get_active_lane_mask || | ||
| Splat.getOpcode() != ISD::SPLAT_VECTOR) | ||
| return SDValue(); | ||
|
|
||
| SDValue Cmp = Splat.getOperand(0); | ||
| if (Cmp.getOpcode() != ISD::SETCC) | ||
| return SDValue(); | ||
davemgreen marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| CondCodeSDNode *Cond = cast<CondCodeSDNode>(Cmp.getOperand(2)); | ||
|
|
||
| auto ComparatorConst = dyn_cast<ConstantSDNode>(Cmp.getOperand(1)); | ||
| if (!ComparatorConst || ComparatorConst->getSExtValue() > 0 || | ||
| Cond->get() != ISD::CondCode::SETLT) | ||
| return SDValue(); | ||
| unsigned CompValue = std::abs(ComparatorConst->getSExtValue()); | ||
| unsigned EltSize = CompValue + 1; | ||
davemgreen marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| if (!isPowerOf2_64(EltSize) || EltSize > 8) | ||
| return SDValue(); | ||
|
|
||
| SDValue Diff = Cmp.getOperand(0); | ||
| if (Diff.getOpcode() != ISD::SUB || Diff.getValueType() != MVT::i64) | ||
| return SDValue(); | ||
|
|
||
| auto LaneMaskConst = dyn_cast<ConstantSDNode>(LaneMask.getOperand(1)); | ||
| if (!LaneMaskConst || LaneMaskConst->getZExtValue() != 0 || | ||
| (EltSize != 1 && LaneMask.getOperand(2).getOpcode() != ISD::SRA)) | ||
| return SDValue(); | ||
|
|
||
| // An alias mask for i8 elements omits the division because it would just | ||
| // divide by 1 | ||
| if (EltSize > 1) { | ||
| SDValue DiffDiv = LaneMask.getOperand(2); | ||
| auto DiffDivConst = dyn_cast<ConstantSDNode>(DiffDiv.getOperand(1)); | ||
|
||
| if (!DiffDivConst || DiffDivConst->getZExtValue() != Log2_64(EltSize)) | ||
| return SDValue(); | ||
| } else if (LaneMask.getOperand(2) != Diff) | ||
| return SDValue(); | ||
|
|
||
| SDValue StorePtr = Diff.getOperand(0); | ||
| SDValue ReadPtr = Diff.getOperand(1); | ||
|
|
||
| unsigned IntrinsicID = 0; | ||
| switch (EltSize) { | ||
| case 1: | ||
| IntrinsicID = Intrinsic::aarch64_sve_whilewr_b; | ||
| break; | ||
| case 2: | ||
| IntrinsicID = Intrinsic::aarch64_sve_whilewr_h; | ||
| break; | ||
| case 4: | ||
| IntrinsicID = Intrinsic::aarch64_sve_whilewr_s; | ||
| break; | ||
| case 8: | ||
| IntrinsicID = Intrinsic::aarch64_sve_whilewr_d; | ||
| break; | ||
| default: | ||
| return SDValue(); | ||
| } | ||
| SDLoc DL(Op); | ||
| SDValue ID = DAG.getConstant(IntrinsicID, DL, MVT::i32); | ||
| return DAG.getNode(ISD::INTRINSIC_WO_CHAIN, DL, Op.getValueType(), ID, | ||
| StorePtr, ReadPtr); | ||
| } | ||
|
|
||
| SDValue AArch64TargetLowering::LowerVectorOR(SDValue Op, | ||
| SelectionDAG &DAG) const { | ||
|
|
||
| if (SDValue SV = tryWhileWRFromOR(Op, DAG)) | ||
| return SV; | ||
| if (useSVEForFixedLengthVectorVT(Op.getValueType(), | ||
| !Subtarget->isNeonAvailable())) | ||
| return LowerToScalableOp(Op, DAG); | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pass Subtarget from the caller.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.