Skip to content

[libc++][numeric][NFC] Cleanup *Saturation arithmetic* tests #101826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 16, 2025
Merged

[libc++][numeric][NFC] Cleanup *Saturation arithmetic* tests #101826

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6e0c6f9
[libc++][numeric][NFC] Cleanup *Saturation arithmetic* tests
H-G-Hristov Aug 3, 2024
d7c9e34
Merge branch 'main' into hgh/libcxx/clean-up_saturation_arithmetic_tests
Zingam Jan 28, 2025
49da766
Merge branch 'main' into hgh/libcxx/clean-up_saturation_arithmetic_tests
Zingam Jan 29, 2025
78927c6
Merge branch 'main' into hgh/libcxx/clean-up_saturation_arithmetic_tests
Zingam Mar 14, 2025
554717f
Merge branch 'main' into hgh/libcxx/clean-up_saturation_arithmetic_tests
Zingam Mar 14, 2025
9f0ae82
Minor tweaks fix CI for AppleClang
H-G-Hristov Mar 15, 2025
8322d01
Merge branch 'main' into hgh/libcxx/clean-up_saturation_arithmetic_tests
H-G-Hristov Mar 15, 2025
6837f7d
Minor tweaks
H-G-Hristov Mar 15, 2025
0cefa3a
Merge branch 'main' into hgh/libcxx/clean-up_saturation_arithmetic_tests
Zingam Mar 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions libcxx/test/std/numerics/numeric.ops/numeric.ops.sat/add_sat.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,7 @@ constexpr bool test_signed() {
constexpr auto minVal = std::numeric_limits<IntegerT>::min();
constexpr auto maxVal = std::numeric_limits<IntegerT>::max();

// TODO(LLVM-20) remove [[maybe_unused]] since all supported compilers support "Placeholder variables with no name"
[[maybe_unused]] std::same_as<IntegerT> decltype(auto) _ = std::add_sat(minVal, maxVal);
std::same_as<IntegerT> decltype(auto) _ = std::add_sat(minVal, maxVal);

static_assert(noexcept(std::add_sat(minVal, maxVal)));

Expand Down Expand Up @@ -97,8 +96,7 @@ constexpr bool test_unsigned() {
constexpr auto minVal = std::numeric_limits<IntegerT>::min();
constexpr auto maxVal = std::numeric_limits<IntegerT>::max();

// TODO(LLVM-20) remove [[maybe_unused]] since all supported compilers support "Placeholder variables with no name"
[[maybe_unused]] std::same_as<IntegerT> decltype(auto) _ = std::add_sat(minVal, maxVal);
std::same_as<IntegerT> decltype(auto) _ = std::add_sat(minVal, maxVal);

static_assert(noexcept(std::add_sat(minVal, maxVal)));

Expand Down
6 changes: 2 additions & 4 deletions libcxx/test/std/numerics/numeric.ops/numeric.ops.sat/div_sat.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,7 @@ constexpr bool test_signed() {
constexpr auto minVal = std::numeric_limits<IntegerT>::min();
constexpr auto maxVal = std::numeric_limits<IntegerT>::max();

// TODO(LLVM-20) remove [[maybe_unused]] and `{}` scope since all supported compilers support "Placeholder variables with no name"
[[maybe_unused]] std::same_as<IntegerT> decltype(auto) _ = std::div_sat(minVal, maxVal);
std::same_as<IntegerT> decltype(auto) _ = std::div_sat(minVal, maxVal);

static_assert(noexcept(std::div_sat(minVal, maxVal)));

Expand Down Expand Up @@ -89,8 +88,7 @@ constexpr bool test_unsigned() {
constexpr auto minVal = std::numeric_limits<IntegerT>::min();
constexpr auto maxVal = std::numeric_limits<IntegerT>::max();

// TODO(LLVM-20) remove [[maybe_unused]] since all supported compilers support "Placeholder variables with no name"
[[maybe_unused]] std::same_as<IntegerT> decltype(auto) _ = std::div_sat(minVal, maxVal);
std::same_as<IntegerT> decltype(auto) _ = std::div_sat(minVal, maxVal);
static_assert(noexcept(std::div_sat(minVal, maxVal)));

// clang-format off
Expand Down
6 changes: 2 additions & 4 deletions libcxx/test/std/numerics/numeric.ops/numeric.ops.sat/mul_sat.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,7 @@ constexpr bool test_signed() {
constexpr auto minVal = std::numeric_limits<IntegerT>::min();
constexpr auto maxVal = std::numeric_limits<IntegerT>::max();

// TODO(LLVM-20) remove [[maybe_unused]] since all supported compilers support "Placeholder variables with no name"
[[maybe_unused]] std::same_as<IntegerT> decltype(auto) _ = std::mul_sat(minVal, maxVal);
std::same_as<IntegerT> decltype(auto) _ = std::mul_sat(minVal, maxVal);

static_assert(noexcept(std::mul_sat(minVal, maxVal)));

Expand Down Expand Up @@ -103,8 +102,7 @@ constexpr bool test_unsigned() {
constexpr auto minVal = std::numeric_limits<IntegerT>::min();
constexpr auto maxVal = std::numeric_limits<IntegerT>::max();

// TODO(LLVM-20) remove [[maybe_unused]] since all supported compilers support "Placeholder variables with no name"
[[maybe_unused]] std::same_as<IntegerT> decltype(auto) _ = std::mul_sat(minVal, maxVal);
std::same_as<IntegerT> decltype(auto) _ = std::mul_sat(minVal, maxVal);

static_assert(noexcept(std::mul_sat(minVal, maxVal)));

Expand Down
Loading
Loading