Skip to content

[lldb] Remove limit on max memory read size #105765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 3, 2024
Merged

[lldb] Remove limit on max memory read size #105765

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6a27ad3
[lldb] Remove limit on max memory read size
jasonmolenda Aug 23, 2024
3d63f0b
Change to using a hex value in .td, fix API test
jasonmolenda Aug 24, 2024
c2c4013
Merge branch 'main' into remove-memory-read-default-1024
jasonmolenda Aug 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lldb/source/Target/TargetProperties.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ let Definition = "target" in {
DefaultUnsignedValue<1024>,
Desc<"Maximum number of characters to show when using %s in summary strings.">;
def MaxMemReadSize: Property<"max-memory-read-size", "UInt64">,
DefaultUnsignedValue<1024>,
DefaultUnsignedValue<4294967295>,
Copy link
Member

@medismailben medismailben Aug 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Either make it hex, or instead of providing a default value here, initialize the CommandOption to UINT32_MAX

Desc<"Maximum number of bytes that 'memory read' will fetch before --force must be specified.">;
def BreakpointUseAvoidList: Property<"breakpoints-use-platform-avoid-list", "Boolean">,
DefaultTrue,
Expand Down