workflows/release-tasks: Pass required secrets to all called workflows #106286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rkflow Called workflows don't have access to secrets by default, so we need to explicitly pass secrets that we need to use.
|
@llvm/pr-subscribers-github-workflow Author: Tom Stellard (tstellar) ChangesCalled workflows don't have access to secrets by default, so we need to explicitly pass secrets that we need to use. Full diff: https://github.com/llvm/llvm-project/pull/106286.diff 1 Files Affected:
diff --git a/.github/workflows/release-tasks.yml b/.github/workflows/release-tasks.yml
index cf42730aaf8170..a6c21193a86df9 100644
--- a/.github/workflows/release-tasks.yml
+++ b/.github/workflows/release-tasks.yml
@@ -97,6 +97,11 @@ jobs:
release-version: ${{ needs.validate-tag.outputs.release-version }}
upload: true
runs-on: ${{ matrix.runs-on }}
+ secrets:
+ # This will be empty for pull_request events, but that's fine, because
+ # the release-binaries workflow does not use this secret for the
+ # pull_request event.
+ RELEASE_TASKS_USER_TOKEN: ${{ secrets.RELEASE_TASKS_USER_TOKEN }}
release-sources:
name: Package Release Sources
|
boomanaiden154
approved these changes
Aug 27, 2024
tstellar
changed the title
|
I've expanded the patch to fix several other places that were missing secrets. |
boomanaiden154
approved these changes
Aug 27, 2024
|
/cherry-pick 9d81e7e |
llvmbot
pushed a commit
to llvmbot/llvm-project
that referenced
this pull request
Aug 29, 2024
llvm#106286) Called workflows don't have access to secrets by default, so we need to explicitly pass secrets that we use. (cherry picked from commit 9d81e7e)
|
/pull-request #106491 |
tru
pushed a commit
to llvmbot/llvm-project
that referenced
this pull request
Sep 1, 2024
llvm#106286) Called workflows don't have access to secrets by default, so we need to explicitly pass secrets that we use. (cherry picked from commit 9d81e7e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Called workflows don't have access to secrets by default, so we need to explicitly pass secrets that we use.