[IR] Account for byte width in m_PtrAdd #106540
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 29, 2024
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Aug 29, 2024
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
s-barannikov
force-pushed
the
users/s-barannikov/byte/4-create-ptradd
branch
from
2a28c47 to
ccdc8a1
Compare
s-barannikov
force-pushed
the
users/s-barannikov/byte/5-match-ptradd
branch
from
7cca421 to
14e8b41
Compare
s-barannikov
force-pushed
the
users/s-barannikov/byte/4-create-ptradd
branch
from
ccdc8a1 to
4d3f0b6
Compare
s-barannikov
force-pushed
the
users/s-barannikov/byte/5-match-ptradd
branch
2 times, most recently
from
61be980 to
222a3b7
Compare
s-barannikov
force-pushed
the
users/s-barannikov/byte/4-create-ptradd
branch
from
4d3f0b6 to
6d95f98
Compare
s-barannikov
force-pushed
the
users/s-barannikov/byte/5-match-ptradd
branch
from
222a3b7 to
26dc400
Compare
s-barannikov
force-pushed
the
users/s-barannikov/byte/4-create-ptradd
branch
from
6d95f98 to
b8c2041
Compare
s-barannikov
force-pushed
the
users/s-barannikov/byte/5-match-ptradd
branch
from
26dc400 to
e75ad5f
Compare
s-barannikov
force-pushed
the
users/s-barannikov/byte/4-create-ptradd
branch
from
b8c2041 to
c335952
Compare
s-barannikov
force-pushed
the
users/s-barannikov/byte/5-match-ptradd
branch
from
e75ad5f to
5604e7a
Compare
s-barannikov
force-pushed
the
users/s-barannikov/byte/4-create-ptradd
branch
from
c335952 to
517a87c
Compare
s-barannikov
force-pushed
the
users/s-barannikov/byte/5-match-ptradd
branch
from
5604e7a to
161e6ba
Compare
s-barannikov
force-pushed
the
users/s-barannikov/byte/4-create-ptradd
branch
from
517a87c to
1655f41
Compare
s-barannikov
force-pushed
the
users/s-barannikov/byte/5-match-ptradd
branch
from
161e6ba to
68b0d70
Compare
s-barannikov
force-pushed
the
users/s-barannikov/byte/4-create-ptradd
branch
from
1655f41 to
caa10b7
Compare
s-barannikov
force-pushed
the
users/s-barannikov/byte/5-match-ptradd
branch
from
68b0d70 to
4d50f23
Compare
The method has few uses yet, so just pass DL argument to it. The change follows m_PtrToIntSameSize, and I don't see a better way of delivering the byte width to the method.
s-barannikov
force-pushed
the
users/s-barannikov/byte/5-match-ptradd
branch
from
4d50f23 to
856e1f0
Compare
s-barannikov
force-pushed
the
users/s-barannikov/byte/4-create-ptradd
branch
from
caa10b7 to
29393ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method has few uses yet, so just pass DL argument to it. The change
follows m_PtrToIntSameSize, and I don't see a better way of delivering
the byte width to the method.