[SimplifyLibCalls] Add initial support for non-8-bit bytes #106542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 29, 2024
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
s-barannikov
force-pushed
the
users/s-barannikov/byte/6-string-info-char-width
branch
from
e5b70fc to
cdb7292
Compare
s-barannikov
force-pushed
the
users/s-barannikov/byte/7-simplify-lib-calls
branch
from
a32b79e to
699b2bc
Compare
s-barannikov
force-pushed
the
users/s-barannikov/byte/6-string-info-char-width
branch
from
cdb7292 to
d27bc30
Compare
s-barannikov
force-pushed
the
users/s-barannikov/byte/7-simplify-lib-calls
branch
from
699b2bc to
c640baf
Compare
s-barannikov
force-pushed
the
users/s-barannikov/byte/6-string-info-char-width
branch
from
d27bc30 to
deca69b
Compare
s-barannikov
force-pushed
the
users/s-barannikov/byte/7-simplify-lib-calls
branch
from
c640baf to
baf4933
Compare
s-barannikov
force-pushed
the
users/s-barannikov/byte/7-simplify-lib-calls
branch
from
baf4933 to
9859c07
Compare
s-barannikov
force-pushed
the
users/s-barannikov/byte/6-string-info-char-width
branch
from
deca69b to
57104d1
Compare
s-barannikov
force-pushed
the
users/s-barannikov/byte/7-simplify-lib-calls
branch
from
9859c07 to
931d15e
Compare
s-barannikov
force-pushed
the
users/s-barannikov/byte/6-string-info-char-width
branch
from
57104d1 to
fe95d64
Compare
s-barannikov
force-pushed
the
users/s-barannikov/byte/7-simplify-lib-calls
branch
from
931d15e to
76b4553
Compare
s-barannikov
force-pushed
the
users/s-barannikov/byte/6-string-info-char-width
branch
from
fe95d64 to
24ff5d6
Compare
s-barannikov
force-pushed
the
users/s-barannikov/byte/7-simplify-lib-calls
branch
from
76b4553 to
bb76990
Compare
s-barannikov
force-pushed
the
users/s-barannikov/byte/6-string-info-char-width
branch
from
24ff5d6 to
0a21746
Compare
s-barannikov
force-pushed
the
users/s-barannikov/byte/7-simplify-lib-calls
branch
2 times, most recently
from
d2b8f2e to
c46fbb9
Compare
s-barannikov
force-pushed
the
users/s-barannikov/byte/6-string-info-char-width
branch
from
0a21746 to
b878d88
Compare
s-barannikov
force-pushed
the
users/s-barannikov/byte/7-simplify-lib-calls
branch
from
c46fbb9 to
4bf7017
Compare
s-barannikov
force-pushed
the
users/s-barannikov/byte/6-string-info-char-width
branch
from
b878d88 to
1591f0b
Compare
s-barannikov
force-pushed
the
users/s-barannikov/byte/7-simplify-lib-calls
branch
from
4bf7017 to
a7b7545
Compare
The patch makes CharWidth argument of `getStringLength` mandatory and ensures the correct values are passed in most cases. This is *not* a complete support for unusual byte widths in SimplifyLibCalls since `getConstantStringInfo` returns false for those. The code guarded by `getConstantStringInfo` returning true is unchanged because the changes are currently not testable.
s-barannikov
force-pushed
the
users/s-barannikov/byte/7-simplify-lib-calls
branch
from
a7b7545 to
73b1913
Compare
s-barannikov
force-pushed
the
users/s-barannikov/byte/6-string-info-char-width
branch
from
1591f0b to
0d66f01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch makes CharWidth argument of
getStringLengthmandatoryand ensures the correct values are passed in most cases.
This is not a complete support for unusual byte widths in
SimplifyLibCalls since
getConstantStringInforeturns false for those.The code guarded by
getConstantStringInforeturning true is unchangedbecause the changes are currently not testable.