-
Notifications
You must be signed in to change notification settings - Fork 15.3k
[RISCV] Add initial support of memcmp expansion #107548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
wangpc-pp
merged 23 commits into
main
from
users/wangpc-pp/spr/riscv-add-initial-support-of-memcmp-expansion
Nov 6, 2024
Merged
Changes from 19 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
f21cfcf
[𝘀𝗽𝗿] initial version
wangpc-pp 2caea13
Fix copt-paste mistake
wangpc-pp 24dc612
[𝘀𝗽𝗿] changes introduced through rebase
wangpc-pp 02812ed
Rebase on tests
wangpc-pp a96e1aa
Don't add 5/6 to AllowedTailExpansions for RV32
wangpc-pp 86b823d
Remove AllowedTailExpansions
wangpc-pp 4749983
[𝘀𝗽𝗿] changes introduced through rebase
wangpc-pp d1a516b
Rebase on new tests.
wangpc-pp e709f8d
Explicitly set the LoadSizes
wangpc-pp 60baf2a
[𝘀𝗽𝗿] changes introduced through rebase
wangpc-pp 7b06db7
Rebase
wangpc-pp 6e34e30
[𝘀𝗽𝗿] changes introduced through rebase
wangpc-pp 8ab1147
Add RUNs with zbb/zbkb
wangpc-pp 6e65dd0
[𝘀𝗽𝗿] changes introduced through rebase
wangpc-pp ed1a930
Add Zbb tests
wangpc-pp a4119f8
[𝘀𝗽𝗿] changes introduced through rebase
wangpc-pp 03946d2
Add signext
wangpc-pp b9a0425
[𝘀𝗽𝗿] changes introduced through rebase
wangpc-pp 39816b2
Reduce CHECKs
wangpc-pp 2fe0d42
Apply suggestion to AllowOverlappingLoads
wangpc-pp d695c49
unaligned only
wangpc-pp 2098099
[𝘀𝗽𝗿] changes introduced through rebase
wangpc-pp 10d5216
Rebase
wangpc-pp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless I'm missing something, there is no check for sufficient alignment on any load generated by ExpandMemCmp, as a result, we can only legally provide a non-byte size if unaligned access is fully supported.
(This is really bug in ExpandMemCmp - it should be asking if the load is properly aligned.)