Skip to content

Conversation

@wangpc-pp
Copy link
Contributor

@wangpc-pp wangpc-pp commented Sep 9, 2024

We add tests for the following cases:

  • Length = 0, 1, 2, 3, 4, 5, 6, 7, 8, 15, 16, 31, 32, 63, 64, 127,
    128, runtime.
  • Comparisons against zero.
  • RUN lines for scalar/vector w/ or w/o strict align.
  • Optimize for size.

Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
Copy link
Collaborator

@preames preames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w/requested change.

Since all of your checks are currently the same for the various configurations, please use --check-prefixes=CHECK,WHATEVER to reduce the duplication.

Created using spr 1.3.6-beta.1
Copy link
Collaborator

@topperc topperc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangpc-pp wangpc-pp merged commit 5adb5c0 into main Nov 6, 2024
8 checks passed
@wangpc-pp wangpc-pp deleted the users/wangpc-pp/spr/riscv-add-tests-for-memcmp-expansion branch November 6, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants