Adding splitdouble HLSL function #109331
Merged
Adding splitdouble HLSL function #109331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaosaffran
force-pushed
the
intrinsics/splitdouble
branch
2 times, most recently
from
cf135e0 to
8f21239
Compare
spall
reviewed
Sep 19, 2024
joaosaffran
force-pushed
the
intrinsics/splitdouble
branch
12 times, most recently
from
6d40fb8 to
13a095c
Compare
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
joaosaffran
force-pushed
the
intrinsics/splitdouble
branch
7 times, most recently
from
0ca7458 to
b7b2831
Compare
llvmbot
added
clang
joaosaffran
force-pushed
the
intrinsics/splitdouble
branch
2 times, most recently
from
4f1cbf3 to
37a5a8a
Compare
bogner
reviewed
Oct 26, 2024
joaosaffran
force-pushed
the
intrinsics/splitdouble
branch
from
24d8571 to
b3d58a8
Compare
joaosaffran
force-pushed
the
intrinsics/splitdouble
branch
from
b3d58a8 to
164c6af
Compare
bogner
approved these changes
Oct 27, 2024
Contributor
bogner
left a comment
bogner
left a comment
There was a problem hiding this comment.
A few last minor nitpicks, but this LGTM!
Comment on lines
+5463
to
+5464
| std::pair<LValue, LValue> | ||
| CodeGenFunction::EmitHLSLOutArgLValues(const HLSLOutArgExpr *E, QualType Ty) { |
Contributor
There was a problem hiding this comment.
Is EmitHLSLOutArgLValues used any other than in CodeGenFunction::EmitHLSLOutArgExpr at this point? I think we can avoid splitting this method in two.
Contributor
Author
There was a problem hiding this comment.
@llvm-beanz, any reason we couldn't merge those methods together?
joaosaffran
force-pushed
the
intrinsics/splitdouble
branch
from
164c6af to
104479d
Compare
NoumanAmir657
pushed a commit
to NoumanAmir657/llvm-project
that referenced
this pull request
Nov 4, 2024
- Adding hlsl `splitdouble` intrinsics - Adding DXIL lowering - Adding SPIRV lowering - Adding test Fixes: llvm#108901 --------- Co-authored-by: Joao Saffran <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
splitdoubleintrinsicsFixes: #108901