Skip to content

[Clang][TableGen] Add explicit symbol visibility macros to code generated #109362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 5, 2024
Merged

[Clang][TableGen] Add explicit symbol visibility macros to code generated #109362

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f4e51ec
[Clang][TableGen] Add explicit symbol visibility macros to code gener…
fsfod Jul 8, 2024
e395af0
Fix formatting
fsfod Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions clang/utils/TableGen/ClangAttrEmitter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2727,7 +2727,8 @@ static void emitAttributes(const RecordKeeper &Records, raw_ostream &OS,
}

if (Header)
OS << "class " << R.getName() << "Attr : public " << SuperName << " {\n";
OS << "class CLANG_ABI " << R.getName() << "Attr : public " << SuperName
<< " {\n";
else
OS << "\n// " << R.getName() << "Attr implementation\n\n";

Expand Down Expand Up @@ -3185,7 +3186,8 @@ void clang::EmitClangAttrClass(const RecordKeeper &Records, raw_ostream &OS) {
emitSourceFileHeader("Attribute classes' definitions", OS, Records);

OS << "#ifndef LLVM_CLANG_ATTR_CLASSES_INC\n";
OS << "#define LLVM_CLANG_ATTR_CLASSES_INC\n\n";
OS << "#define LLVM_CLANG_ATTR_CLASSES_INC\n";
OS << "#include \"clang/Support/Compiler.h\"\n\n";

emitAttributes(Records, OS, true);

Expand Down
Loading