[AMDGPU] Correct pass dependencies for SILowerSGPRSpills #109937
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @optimisan and the rest of your teammates on |
This was referenced Sep 25, 2024
Member
|
@llvm/pr-subscribers-backend-amdgpu Author: Akshat Oke (Akshat-Oke) ChangesFull diff: https://github.com/llvm/llvm-project/pull/109937.diff 1 Files Affected:
diff --git a/llvm/lib/Target/AMDGPU/SILowerSGPRSpills.cpp b/llvm/lib/Target/AMDGPU/SILowerSGPRSpills.cpp
index d385261184e718..dcdac5a0942ab4 100644
--- a/llvm/lib/Target/AMDGPU/SILowerSGPRSpills.cpp
+++ b/llvm/lib/Target/AMDGPU/SILowerSGPRSpills.cpp
@@ -83,7 +83,7 @@ char SILowerSGPRSpillsLegacy::ID = 0;
INITIALIZE_PASS_BEGIN(SILowerSGPRSpillsLegacy, DEBUG_TYPE,
"SI lower SGPR spill instructions", false, false)
INITIALIZE_PASS_DEPENDENCY(LiveIntervalsWrapperPass)
-INITIALIZE_PASS_DEPENDENCY(VirtRegMapWrapperPass)
+INITIALIZE_PASS_DEPENDENCY(SlotIndexesWrapperPass)
INITIALIZE_PASS_END(SILowerSGPRSpillsLegacy, DEBUG_TYPE,
"SI lower SGPR spill instructions", false, false)
|
arsenm
reviewed
Sep 25, 2024
Contributor
arsenm
left a comment
arsenm
left a comment
There was a problem hiding this comment.
Description needs to be more specific
optimisan
force-pushed
the
users/Akshat-Oke/port-vrm
branch
from
091304c to
b1d74ad
Compare
optimisan
force-pushed
the
users/Akshat-Oke/update-dep
branch
from
ea4b201 to
7b68d9f
Compare
Contributor
Bump |
optimisan
force-pushed
the
users/Akshat-Oke/update-dep
branch
from
7b68d9f to
a1925ae
Compare
Contributor
Author
|
ping |
Contributor
Fix the description |
optimisan
force-pushed
the
users/Akshat-Oke/port-vrm
branch
from
b1d74ad to
ccf824b
Compare
optimisan
force-pushed
the
users/Akshat-Oke/update-dep
branch
from
a1925ae to
ca68507
Compare
Contributor
Author
|
Also updated in PR. |
arsenm
requested changes
Oct 14, 2024
Contributor
arsenm
left a comment
arsenm
left a comment
There was a problem hiding this comment.
Description still not fixed
cdevadas
changed the title
cdevadas
changed the title
optimisan
changed the title
optimisan
force-pushed
the
users/Akshat-Oke/port-vrm
branch
from
ccf824b to
ff93403
Compare
optimisan
force-pushed
the
users/Akshat-Oke/update-dep
branch
from
ca68507 to
db91ca0
Compare
optimisan
force-pushed
the
users/Akshat-Oke/port-vrm
branch
from
ff93403 to
a3d67dd
Compare
optimisan
force-pushed
the
users/Akshat-Oke/update-dep
branch
from
db91ca0 to
dee5a29
Compare
Contributor
Author
|
I think this describes it better? |
arsenm
changed the title
arsenm
approved these changes
Oct 21, 2024
optimisan
force-pushed
the
users/Akshat-Oke/port-vrm
branch
from
a3d67dd to
8a82e45
Compare
optimisan
force-pushed
the
users/Akshat-Oke/update-dep
branch
from
dee5a29 to
2cd5b9b
Compare
Contributor
Author
optimisan
force-pushed
the
users/Akshat-Oke/port-vrm
branch
from
8a82e45 to
cb4a3b2
Compare
Replace the unused analysis (VirtRegMap) dependency with the used one (SlotIndexes). This initializes `SlotIndexesWrapperPass` which is used by SILowerSGPRSpills to ensure that legacy pass manager finds it. Removes the initialization for `VirtRegMapWrapperLegacy` pass since it is not requested in this pass.
optimisan
force-pushed
the
users/Akshat-Oke/update-dep
branch
from
2cd5b9b to
8dbbf81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace unused analysis (VirtRegMap) dependency with the used one (SlotIndexes)
Initializes
SlotIndexesWrapperPasswhich is used by SILowerSGPRSpills to ensure that legacy pass manager finds it.Removes the initialization for
VirtRegMapWrapperPasssince it is not requested in this pass.