Skip to content

[MLIR] Make OneShotModuleBufferize use OpInterface #110322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Oct 1, 2024
Merged

[MLIR] Make OneShotModuleBufferize use OpInterface #110322

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
8a5aca2
Make OneShotModuleBufferize accept FunctionOpInterface and CallOpInte…
tzunghanjuang Sep 4, 2024
5153af3
Cleanup
tzunghanjuang Sep 4, 2024
1f8d847
Make getAssumedUniqueReturnOp detect ReturnLike and FuncAnalysisState…
tzunghanjuang Sep 6, 2024
26e69ad
Make getAssumedUniqueReturnOp return funcOp if there is no return
tzunghanjuang Sep 6, 2024
074192c
Use getNumResults to guard functions without any return type
tzunghanjuang Sep 6, 2024
4ba535b
Update mlir/lib/Dialect/Bufferization/Transforms/OneShotModuleBufferi…
Sep 10, 2024
caa69cd
Update mlir/lib/Dialect/Bufferization/Transforms/OneShotModuleBufferi…
Sep 10, 2024
eb2f888
Update mlir/lib/Dialect/Bufferization/Transforms/OneShotModuleBufferi…
Sep 10, 2024
695b945
Add debug-payload-root-tag to transform.named_sequence tests
tzunghanjuang Sep 10, 2024
aca0e78
Add transform.target_tag to CHH/full.mlir
tzunghanjuang Sep 11, 2024
913ab76
Create a pass pipeline on nested modules in mlir/test/Examples/transf…
tzunghanjuang Sep 16, 2024
1811994
Make FunctionArgTypeConverterFn use FunctionOpInterface
tzunghanjuang Sep 17, 2024
73f7e86
Fix formatting issues
tzunghanjuang Sep 24, 2024
8d78000
Skip function call analysis for CallIndirectOp
tzunghanjuang Sep 27, 2024
f3b55a1
Update mlir/lib/Dialect/Bufferization/Transforms/OneShotModuleBufferi…
Sep 30, 2024
6c6f889
Patch another function call assertion
tzunghanjuang Sep 30, 2024
4a60687
Remove CallIndirectOp skip
tzunghanjuang Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions mlir/lib/Dialect/Bufferization/Transforms/OneShotModuleBufferize.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,9 @@ static void equivalenceAnalysis(FunctionOpInterface funcOp,
OneShotAnalysisState &state,
FuncAnalysisState &funcState) {
funcOp->walk([&](CallOpInterface callOp) {
if (isa<func::CallIndirectOp>(callOp))
return WalkResult::skip();

FunctionOpInterface calledFunction = getCalledFunction(callOp);
assert(calledFunction && "could not retrieved called FunctionOpInterface");

Expand Down Expand Up @@ -308,6 +311,9 @@ getFuncOpsOrderedByCalls(ModuleOp moduleOp,
// Collect function calls and populate the caller map.
numberCallOpsContainedInFuncOp[funcOp] = 0;
return funcOp.walk([&](CallOpInterface callOp) -> WalkResult {
if (isa<func::CallIndirectOp>(callOp))
return WalkResult::skip();

FunctionOpInterface calledFunction = getCalledFunction(callOp);
assert(calledFunction &&
"could not retrieved called FunctionOpInterface");
Expand Down