Skip to content

Conversation

@jurahul
Copy link
Contributor

@jurahul jurahul commented Oct 1, 2024

Rename generatedUnsignedRemainderCode to generateUnsignedRemainderCode.

Rename `generatedUnsignedRemainderCode` to  `generateUnsignedRemainderCode`.
@jurahul jurahul marked this pull request as ready for review October 2, 2024 02:56
@jurahul jurahul requested a review from kazutakahirata October 2, 2024 02:57
@llvmbot
Copy link
Member

llvmbot commented Oct 2, 2024

@llvm/pr-subscribers-llvm-transforms

Author: Rahul Joshi (jurahul)

Changes

Rename generatedUnsignedRemainderCode to generateUnsignedRemainderCode.


Full diff: https://github.com/llvm/llvm-project/pull/110743.diff

1 Files Affected:

  • (modified) llvm/lib/Transforms/Utils/IntegerDivision.cpp (+4-5)
diff --git a/llvm/lib/Transforms/Utils/IntegerDivision.cpp b/llvm/lib/Transforms/Utils/IntegerDivision.cpp
index cea095408b0c39..11956816a6ec3f 100644
--- a/llvm/lib/Transforms/Utils/IntegerDivision.cpp
+++ b/llvm/lib/Transforms/Utils/IntegerDivision.cpp
@@ -70,8 +70,8 @@ static Value *generateSignedRemainderCode(Value *Dividend, Value *Divisor,
 /// code generated, e.g. at the urem instruction. This will generate a udiv in
 /// the process, and Builder's insert point will be pointing at the udiv (if
 /// present, i.e. not folded), ready to be expanded if the user wishes
-static Value *generatedUnsignedRemainderCode(Value *Dividend, Value *Divisor,
-                                             IRBuilder<> &Builder) {
+static Value *generateUnsignedRemainderCode(Value *Dividend, Value *Divisor,
+                                            IRBuilder<> &Builder) {
   // Remainder = Dividend - Quotient*Divisor
 
   // Following instructions are generated for both i32 and i64
@@ -381,9 +381,8 @@ bool llvm::expandRemainder(BinaryOperator *Rem) {
     Rem = BO;
   }
 
-  Value *Remainder = generatedUnsignedRemainderCode(Rem->getOperand(0),
-                                                    Rem->getOperand(1),
-                                                    Builder);
+  Value *Remainder = generateUnsignedRemainderCode(Rem->getOperand(0),
+                                                   Rem->getOperand(1), Builder);
 
   Rem->replaceAllUsesWith(Remainder);
   Rem->dropAllReferences();

Copy link
Contributor

@kazutakahirata kazutakahirata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@jurahul jurahul merged commit 5a40bc2 into llvm:main Oct 2, 2024
8 checks passed
@jurahul jurahul deleted the fix_typo_generatedUnsignedRemainderCode branch October 2, 2024 13:05
Sterling-Augustine pushed a commit to Sterling-Augustine/llvm-project that referenced this pull request Oct 3, 2024
…m#110743)

Rename `generatedUnsignedRemainderCode` to
`generateUnsignedRemainderCode`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants