Skip to content

[rtsan] Add test to ensure coroutines get caught #111049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[rtsan] Add test to ensure coroutines get caught #111049

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions compiler-rt/test/rtsan/coroutine.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
// RUN: %clangxx -std=c++20 -fsanitize=realtime %s -o %t
Copy link
Contributor Author

@cjappl cjappl Oct 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only valid in C++20, what should I do to ensure it doesn't affect systems without c++20? This test should be a no-op in that case

Copy link
Contributor

@fmayer fmayer Oct 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is a system without C++20? This is a test of clang trunk, which supports C++20?

Copy link
Contributor Author

@cjappl cjappl Oct 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When running through this test on one of my older ubuntu machines, I get this error:

/test_radsan/llvm-project/compiler-rt/test/rtsan/coroutine.cpp:7:10: fatal error: 'coroutine' file not found
    7 | #include <coroutine>                                                                                                                                        |          ^~~~~~~~~~~

That led me to believe that I needed to do something special here.

Copy link
Contributor

@fmayer fmayer Oct 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, hmm, yes that makes sense, you are right. That means the lib(std)c++ it uses is too old.

// RUN: not %run %t 2>&1 | FileCheck %s
// UNSUPPORTED: ios

// Intent: Coroutines allocate memory and are not allowed in a [[clang::nonblocking]] function.

#include <coroutine>

struct SimpleCoroutine {
struct promise_type {
SimpleCoroutine get_return_object() { return SimpleCoroutine{}; }
std::suspend_never initial_suspend() { return {}; }
std::suspend_never final_suspend() noexcept { return {}; }
void unhandled_exception() {}
void return_void() {}
};
};

SimpleCoroutine example_coroutine() { co_return; }

void calls_a_coroutine() [[clang::nonblocking]] { example_coroutine(); }

int main() {
calls_a_coroutine();
return 0;
}

// CHECK: ==ERROR: RealtimeSanitizer

// Somewhere in the stack this should be mentioned
// CHECK: calls_a_coroutine
Loading