[LangRef] Fix mislabeling in calling convention name (NFC) #111256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@llvm/pr-subscribers-llvm-ir Author: Antonio Frighetto (antoniofrighetto) ChangesWe have explained how musttail can be guaranteed when the calling convention is not Full diff: https://github.com/llvm/llvm-project/pull/111256.diff 1 Files Affected:
diff --git a/llvm/docs/LangRef.rst b/llvm/docs/LangRef.rst
index 6fa35486669d69..1dd4279efcfb68 100644
--- a/llvm/docs/LangRef.rst
+++ b/llvm/docs/LangRef.rst
@@ -12747,7 +12747,7 @@ This instruction requires several arguments:
- The caller and callee prototypes must match. Pointer types of parameters
or return types may differ in pointee type, but not in address space.
- On the other hand, if the calling convention is `swifttailcc` or `swiftcc`:
+ On the other hand, if the calling convention is `swifttailcc` or `tailcc`:
- Only these ABI-impacting attributes attributes are allowed: sret, byval,
swiftself, and swiftasync.
|
Contributor
Author
|
Kind ping @TNorthover as original author. |
Contributor
Author
|
Kind ping. |
nikic
approved these changes
Nov 11, 2024
antoniofrighetto
force-pushed
the
feature/langref-tailcc-attrs
branch
from
a5323a5 to
11b9bd4
Compare
We have explained how musttail can be guaranteed when the calling convention is not `swifttailcc` or `tailcc`, ensure what needs to adhere when it is the opposite case.
antoniofrighetto
force-pushed
the
feature/langref-tailcc-attrs
branch
from
11b9bd4 to
9fc4654
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have explained how musttail can be guaranteed when the calling convention is not
swifttailccortailcc, ensure what needs to adhere when it is the opposite case (reflect how it is already handled in Verifier).