Fix compile errors in gold plugin #111402
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
NuriAmari
force-pushed
the
users/NuriAmari/fix-gold-plugin-build
branch
2 times, most recently
from
ddddecf to
0267379
Compare
llvm#109847 inadvertently introduced compile errors to the gold plugin. This PR fixes the issue.
NuriAmari
force-pushed
the
users/NuriAmari/fix-gold-plugin-build
branch
from
0267379 to
71cfa84
Compare
Member
|
@llvm/pr-subscribers-lto Author: Nuri Amari (NuriAmari) Changes#109847 inadvertently introduced compile errors to the gold plugin. This PR fixes the issue. Full diff: https://github.com/llvm/llvm-project/pull/111402.diff 1 Files Affected:
diff --git a/llvm/tools/gold/gold-plugin.cpp b/llvm/tools/gold/gold-plugin.cpp
index 9304bd4188d9ed..6d0021c85f20fb 100644
--- a/llvm/tools/gold/gold-plugin.cpp
+++ b/llvm/tools/gold/gold-plugin.cpp
@@ -899,7 +899,7 @@ static std::unique_ptr<LTO> createLTO(IndexWriteCallback OnIndexWrite,
std::string OldPrefix, NewPrefix;
getThinLTOOldAndNewPrefix(OldPrefix, NewPrefix);
Backend = createWriteIndexesThinBackend(
- llvm::hardware_concurrency(options::Parallelism) OldPrefix, NewPrefix,
+ llvm::hardware_concurrency(options::Parallelism), OldPrefix, NewPrefix,
// TODO: Add support for optional native object path in
// thinlto_prefix_replace option to match lld.
/*NativeObjectPrefix=*/"", options::thinlto_emit_imports_files,
|
Contributor
Author
|
Closing in favor of #111412 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#109847 inadvertently introduced compile errors to the gold plugin. This PR fixes the issue.