Skip to content

[lldb] Add early CMake check for 'make' tool #111531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 10, 2024
+19 −4
Merged

[lldb] Add early CMake check for 'make' tool #111531

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c7356d3
[lldb] Add early CMake check for 'make' tool
weliveindetail Oct 8, 2024
5e7bc2d
Pass make as an explicit argument to dotest.py
weliveindetail Oct 9, 2024
908f086
Fix Python code format detail
weliveindetail Oct 9, 2024
3f6b93d
[lldb] Generalize make tool detection in CMake
weliveindetail Oct 9, 2024
994cb5a
Drop special-case for BSDs in dotest.py
weliveindetail Oct 9, 2024
2ce0f99
Drop quoting for the make tool path in dotest.py
weliveindetail Oct 10, 2024
7405281
Detect make and gmake in a single CMake find_program and drop special…
weliveindetail Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions lldb/test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,18 @@ if(LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS)
"`LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS=OFF`")
endif()
endforeach()

# On Windows make is not part of the MSYS tools that llvm-lit takes care of
find_program(MAKE_TOOL make)
if(MAKE_TOOL)
message(STATUS "Found make: ${MAKE_TOOL}")
else()
message(STATUS "Not found: make")
message(SEND_ERROR
"LLDB tests require 'make' tool. Please install and add it to Path "
"(or otherwise disable strict testing requirements with "
"`LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS=OFF`)")
endif()
endif()

if(LLDB_BUILT_STANDALONE)
Expand Down
Loading