Skip to content

[mlir][llvmir] Added extra builders for CallInstrinsicOp #111664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 10, 2024
+37 −0
Merged

[mlir][llvmir] Added extra builders for CallInstrinsicOp #111664

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6be01c8
[mlir][llvmir] Added extra builders for CallInstrinsicOp
FMarno Oct 9, 2024
a5d76f1
fixup! [mlir][llvmir] Added extra builders for CallInstrinsicOp
FMarno Oct 9, 2024
f9c3cf4
fixup! [mlir][llvmir] Added extra builders for CallInstrinsicOp
FMarno Oct 9, 2024
01987e9
Added a couple more builders for call instrinsic op
FMarno Oct 9, 2024
1e7bd93
fixup! Added a couple more builders for call instrinsic op
FMarno Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions mlir/include/mlir/Dialect/LLVMIR/LLVMOps.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1943,6 +1943,11 @@ def LLVM_CallIntrinsicOp
attr-dict
}];

let builders = [
OpBuilder<(ins "Type": $results, "StringAttr":$intrin, "ValueRange":$args)>,
OpBuilder<(ins "TypeRange": $results, "StringAttr":$intrin, "ValueRange":$args, "FastmathFlagsAttr":$fastMathFlags)>
];
Copy link
Member

@Lancern Lancern Oct 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could also include builders for intrinsics that do not have a result type?

OpBuilder<(ins "StringAttr":$intrin, "ValueRange":$args)>
OpBuilder<(ins "StringAttr":$intrin, "ValueRange":$args, "FastmathFlagsAttr":$fastMathFlags)>

Copy link
Contributor Author

@FMarno FMarno Oct 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review.
I've added those in. Do you know how I could confirm they work? I don't really have a use cause so I was just guessing.

Copy link
Member

@Lancern Lancern Oct 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another approach might be adding a unit test under mlir/unittests/Dialect/LLVMIR. But it seems like few people ever do this ... Anyway this builder is fairly simple and I believe it should be OK if no reviewers have problems about it.


let hasVerifier = 1;
}

Expand Down
19 changes: 19 additions & 0 deletions mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3353,6 +3353,25 @@ struct LLVMOpAsmDialectInterface : public OpAsmDialectInterface {
};
} // namespace

//===----------------------------------------------------------------------===//
// CallIntrinsicOp
//===----------------------------------------------------------------------===//

void CallIntrinsicOp::build(OpBuilder &builder, OperationState &state,
mlir::TypeRange results, mlir::StringAttr intrin,
mlir::ValueRange args,
mlir::LLVM::FastmathFlagsAttr fastMathFlags) {

build(builder, state, results, intrin, args, fastMathFlags,
llvm::ArrayRef<mlir::ValueRange>{});
}
void CallIntrinsicOp::build(OpBuilder &builder, OperationState &state,
mlir::Type results, mlir::StringAttr intrin,
mlir::ValueRange args) {
build(builder, state, {results}, intrin, args, FastmathFlagsAttr{},
llvm::ArrayRef<mlir::ValueRange>{});
}

//===----------------------------------------------------------------------===//
// LinkerOptionsOp
//===----------------------------------------------------------------------===//
Expand Down
Loading