Skip to content

Conversation

@easyonaadit
Copy link
Contributor

@easyonaadit easyonaadit commented Oct 10, 2024

Some VOP3 instructions are commutable, but have not been
defined as such, hence they are not merged by Machine-cse.
The isCommutable attribute has been added to them now.
For swapping operands in an instruction, there was no support
if both operands were literals, I have added support for swapping
two literals as well. (SIInstrInfo.cpp: commuteInstructionImpl)

This fixes #111205.

@github-actions
Copy link

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@easyonaadit easyonaadit changed the title added isCommutable attribute to V_ADD_NC_U16 [AMDGPU} Added isCommutable attribute to V_ADD_NC_U16 Oct 10, 2024
@easyonaadit easyonaadit changed the title [AMDGPU} Added isCommutable attribute to V_ADD_NC_U16 [AMDGPU] Added isCommutable attribute to V_ADD_NC_U16 Oct 10, 2024
@easyonaadit easyonaadit force-pushed the VOP3-commute branch 4 times, most recently from 453e627 to f114f57 Compare October 20, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[amdgpu] some VOP3 instructions not defined as commutable

1 participant