[lldb][test] Fixed the test no_unique_address-with-bitfields
#111902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) ChangesFixed the error Full diff: https://github.com/llvm/llvm-project/pull/111902.diff 1 Files Affected:
diff --git a/lldb/test/Shell/SymbolFile/DWARF/no_unique_address-with-bitfields.cpp b/lldb/test/Shell/SymbolFile/DWARF/no_unique_address-with-bitfields.cpp
index 980180e7be9aef..2d7316cf11bdc4 100644
--- a/lldb/test/Shell/SymbolFile/DWARF/no_unique_address-with-bitfields.cpp
+++ b/lldb/test/Shell/SymbolFile/DWARF/no_unique_address-with-bitfields.cpp
@@ -8,6 +8,8 @@
// RUN: -o "image dump ast" \
// RUN: -o exit | FileCheck %s
+// REQUIRES: system-darwin
+
// CHECK: (lldb) image dump ast
// CHECK: CXXRecordDecl {{.*}} struct Foo definition
// CHECK: |-FieldDecl {{.*}} data 'char[5]'
|
Collaborator
|
Running on Darwin is not required for |
Fixed the error `unable to create target: 'No available targets are compatible with triple "x86_64-apple-macosx10.4.0"'`.
slydiman
force-pushed
the
lldb-fix-no_unique_address-with-bitfields
branch
from
0bb01d3 to
7827659
Compare
Contributor
Author
Done. |
labath
approved these changes
Oct 11, 2024
Member
|
Can we do this for all the |
Collaborator
|
I would recommend that -- then you wouldn't need to worry about how to spell [[no_unique_address]] on windows. |
Michael137
added a commit
to Michael137/llvm-project
that referenced
this pull request
Oct 16, 2024
Follow up to llvm#111902. Makes sure all the `no_unique_address` tests are in the same place and we don't rely on the host compiler. Now that we don't compile with the host compiler, this patch also adds `-c` to the compilation command since we don't actually need the linked binary in the test anyway (and on Darwin linking through Clang requires the `xcrun` prefix to set up the SDK paths, etc.). We already do this in `no_unique_address-with-bitfields.cpp` anyway.
Member
|
Michael137
added a commit
that referenced
this pull request
Oct 16, 2024
…tests (#112523) Follow up to #111902. Makes sure all the `no_unique_address` tests are in the same place and we don't rely on the host target triple (which means we don't need to account for `[[msvc::no_unique_address]]` on Windows). Now that we don't compile with the host compiler, this patch also adds `-c` to the compilation command since we don't actually need the linked binary in the test anyway (and on Darwin linking through Clang requires the `xcrun` prefix to set up the SDK paths, etc.). We already do this in `no_unique_address-with-bitfields.cpp` anyway.
DanielCChen
pushed a commit
to DanielCChen/llvm-project
that referenced
this pull request
Oct 16, 2024
…111902) Fixed the error `unable to create target: 'No available targets are compatible with triple "x86_64-apple-macosx10.4.0"'` running `clang --target=x86_64-apple-macosx -c -gdwarf -o %t %s`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the error
unable to create target: 'No available targets are compatible with triple "x86_64-apple-macosx10.4.0"'runningclang --target=x86_64-apple-macosx -c -gdwarf -o %t %s.