Skip to content

[MLIR][BUILD] Fix Unicode build issue on Windows. #112300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 18, 2024
+9 −10
Merged

[MLIR][BUILD] Fix Unicode build issue on Windows. #112300

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
76e6ecf
[MLIR][BUILD] Fix Unicode build issue on Windows.
harrisonGPU Oct 15, 2024
cde0eba
[MLIR][BUILD] Update code for comments.
harrisonGPU Oct 16, 2024
a8843c3
Merge branch 'main' into harrison/dix
harrisonGPU Oct 16, 2024
aa92335
Merge branch 'main' into harrison/dix
harrisonGPU Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions mlir/tools/mlir-rewrite/mlir-rewrite.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,25 +320,25 @@ LogicalResult markRanges(RewritePad &rewriteState, raw_ostream &os) {
for (auto it : rewriteState.getOpDefs()) {
auto [startOp, endOp] = getOpRange(it);

rewriteState.insertText(startOp, "《");
rewriteState.insertText(endOp, "》");
rewriteState.insertText(startOp, " <");
rewriteState.insertText(endOp, "> ");

auto nameRange = getOpNameRange(it);

if (isGeneric(it)) {
rewriteState.insertText(nameRange.Start, "〖");
rewriteState.insertText(nameRange.End, "〗");
rewriteState.insertText(nameRange.Start, " [");
rewriteState.insertText(nameRange.End, "] ");
} else {
rewriteState.insertText(nameRange.Start, "〔");
rewriteState.insertText(nameRange.End, "〕");
rewriteState.insertText(nameRange.Start, " [");
Copy link
Member

@jpienaar jpienaar Oct 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets perhaps make this something like " ![" and "]! " - previously one could differentiate between generic or not form.

Copy link
Contributor Author

@harrisonGPU harrisonGPU Oct 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I have already updated it.

rewriteState.insertText(nameRange.End, "] ");
}
}

// Highlight all comment lines.
// TODO: Could be replaced if this is kept in memory.
for (auto commentLine : rewriteState.getSingleLineComments()) {
rewriteState.insertText(commentLine.Start, "❰");
rewriteState.insertText(commentLine.End, "❱");
rewriteState.insertText(commentLine.Start, "{");
rewriteState.insertText(commentLine.End, "}");
}

return success();
Expand Down
Loading