Skip to content

[Verifier] Verify attribute denormal-fp-math[-f32] #112310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 15, 2024
Merged

[Verifier] Verify attribute denormal-fp-math[-f32] #112310

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
44accc6
[Verifier] Verify attribute `denormal-fp-math[-f32]`
dtcxzyw Oct 15, 2024
0848fc0
[Verifier] Address reviewe comments. NFC.
dtcxzyw Oct 15, 2024
f237ec0
[Verifier] Address review comments. NFC.
dtcxzyw Oct 15, 2024
c14b0bb
[Verifier] Use `--implicit-check-not`
dtcxzyw Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions llvm/test/Verifier/denormal-fp-math.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
; RUN: not llvm-as %s -o /dev/null 2>&1 | FileCheck %s

; CHECK-NOT: invalid value for 'denormal-fp-math' attribute
Copy link
Contributor

@arsenm arsenm Oct 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too fragile negative check on exact string. Use implicit-check-not for the broadest error check. Or just delete the valid case, verifier tests usually don't include them (those go in test/Assembler)

define float @test_denormal_fp_math_valid() "denormal-fp-math"="ieee,ieee" {
ret float 1.0
}
Expand Down
Loading