Skip to content

[IR] Add support for samesign in Operator::hasPoisonGeneratingFlags #112358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 15, 2024
+24 −0
Merged

[IR] Add support for samesign in Operator::hasPoisonGeneratingFlags #112358

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3046d48
[InstCombine] Add pre-commit tests. NFC.
dtcxzyw Oct 15, 2024
d3e1068
[IR] Add support for `samesign` in `Operator::hasPoisonGeneratingFlags`
dtcxzyw Oct 15, 2024
3dd63d9
[InstCombine] Add a test for logical or
dtcxzyw Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions llvm/lib/IR/Operator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@ bool Operator::hasPoisonGeneratingFlags() const {
if (auto *NNI = dyn_cast<PossiblyNonNegInst>(this))
return NNI->hasNonNeg();
return false;
case Instruction::ICmp:
return cast<ICmpInst>(this)->hasSameSign();
default:
if (const auto *FP = dyn_cast<FPMathOperator>(this))
return FP->hasNoNaNs() || FP->hasNoInfs();
Expand Down
11 changes: 11 additions & 0 deletions llvm/test/Transforms/InstCombine/icmp.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5365,3 +5365,14 @@ define i1 @icmp_and_inv_pow2_or_zero_ne_0(i32 %A, i32 %B) {
%cmp = icmp ne i32 %and, 0
ret i1 %cmp
}

define i1 @icmp_samesign_logical_and(i32 %In) {
; CHECK-LABEL: @icmp_samesign_logical_and(
; CHECK-NEXT: [[C2:%.*]] = icmp eq i32 [[IN:%.*]], 1
; CHECK-NEXT: ret i1 [[C2]]
;
%c1 = icmp samesign sgt i32 %In, -1
%c2 = icmp samesign eq i32 %In, 1
%V = select i1 %c1, i1 %c2, i1 false
ret i1 %V
}
Loading