Skip to content

[SROA] Prevent load atomic vector from being generated #112432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

[SROA] Prevent load atomic vector from being generated #112432

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
cb05b56
[SROA] Prevent load atomic vector from being generated
jofrn Oct 15, 2024
0c61505
Autogenerate assertions
jofrn Oct 15, 2024
083346d
Add i32,ptr tests and rename variables
jofrn Oct 16, 2024
cf47505
memcpy size must be >=8 to generate load atomic <1 x ptr>
jofrn Oct 17, 2024
ef4fe92
Use isValidAtomicTy
jofrn Oct 18, 2024
bdebaa8
Add AtomicOrdering to isValidAtomicTy interface
jofrn Oct 18, 2024
d68d923
Updated basictest.ll for checking getTypeSizeInBits
jofrn Oct 18, 2024
1c1aae7
Revert basictest.ll changes and DL check
jofrn Oct 18, 2024
67e0560
Add <2 x i32> test. Add DL as optional to isValidAtomicTy
jofrn Oct 20, 2024
e2e58ee
Added nonbyte test. Removed interface to isValidAtomicTy.
jofrn Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions llvm/test/Transforms/SROA/basictest.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1332,10 +1332,10 @@ define void @PR15674(ptr %data, ptr %src, i32 %size) {
; CHECK-NEXT: entry:
; CHECK-NEXT: [[TMP_SROA_0:%.*]] = alloca i32, align 4
; CHECK-NEXT: switch i32 [[SIZE:%.*]], label [[END:%.*]] [
; CHECK-NEXT: i32 4, label [[BB4:%.*]]
; CHECK-NEXT: i32 3, label [[BB3:%.*]]
; CHECK-NEXT: i32 2, label [[BB2:%.*]]
; CHECK-NEXT: i32 1, label [[BB1:%.*]]
; CHECK-NEXT: i32 4, label [[BB4:%.*]]
; CHECK-NEXT: i32 3, label [[BB3:%.*]]
; CHECK-NEXT: i32 2, label [[BB2:%.*]]
; CHECK-NEXT: i32 1, label [[BB1:%.*]]
; CHECK-NEXT: ]
; CHECK: bb4:
; CHECK-NEXT: [[SRC_GEP3:%.*]] = getelementptr inbounds i8, ptr [[SRC:%.*]], i32 3
Expand Down Expand Up @@ -1971,7 +1971,7 @@ bb7:
define i32 @load_atomic_volatile_past_end() {
; CHECK-LABEL: @load_atomic_volatile_past_end(
; CHECK-NEXT: [[A:%.*]] = alloca i1, align 1
; CHECK-NEXT: [[A_0_V:%.*]] = load atomic volatile i32, ptr [[A]] seq_cst, align 1
; CHECK-NEXT: [[A_0_V:%.*]] = load atomic volatile i32, ptr [[A]] seq_cst, align 4
; CHECK-NEXT: ret i32 [[A_0_V]]
;
%a = alloca i1, align 1
Expand All @@ -1992,8 +1992,9 @@ define i32 @load_volatile_past_end() {

define i32 @load_atomic_past_end() {
; CHECK-LABEL: @load_atomic_past_end(
; CHECK-NEXT: [[A_0_LOAD_EXT:%.*]] = zext i1 undef to i32
; CHECK-NEXT: ret i32 [[A_0_LOAD_EXT]]
; CHECK-NEXT: [[A:%.*]] = alloca i1, align 1
; CHECK-NEXT: [[V:%.*]] = load atomic i32, ptr [[A]] seq_cst, align 4
; CHECK-NEXT: ret i32 [[V]]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to this test, we may want to check only the type without DL. Adding too many checks hinders optimization.

;
%a = alloca i1, align 1
%v = load atomic i32, ptr %a seq_cst, align 4
Expand Down
Loading