Skip to content

[AMDGPU] Allow casts between the Global and Constant Addr Spaces in isValidAddrSpaceCast #112493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ritter-x2a merged 3 commits into from
Oct 22, 2024
Merged

[AMDGPU] Allow casts between the Global and Constant Addr Spaces in isValidAddrSpaceCast #112493

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aea773c
[AMDGPU] Allow casts between the Global and Constant Addr Spaces in i…
ritter-x2a Oct 16, 2024
2787983
fixup! [AMDGPU] Allow casts between the Global and Constant Addr Spac…
ritter-x2a Oct 18, 2024
0d29726
fixup! fixup! [AMDGPU] Allow casts between the Global and Constant Ad…
ritter-x2a Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions llvm/lib/Target/AMDGPU/AMDGPUTargetTransformInfo.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,9 +187,12 @@ class GCNTTIImpl final : public BasicTTIImplBase<GCNTTIImpl> {
}
return false;
}
if ((FromAS == AMDGPUAS::CONSTANT_ADDRESS_32BIT &&
ToAS == AMDGPUAS::CONSTANT_ADDRESS) ||
(FromAS == AMDGPUAS::CONSTANT_ADDRESS &&
if (FromAS != ToAS &&
(FromAS == AMDGPUAS::GLOBAL_ADDRESS ||
FromAS == AMDGPUAS::CONSTANT_ADDRESS ||
FromAS == AMDGPUAS::CONSTANT_ADDRESS_32BIT) &&
(ToAS == AMDGPUAS::GLOBAL_ADDRESS ||
ToAS == AMDGPUAS::CONSTANT_ADDRESS ||
ToAS == AMDGPUAS::CONSTANT_ADDRESS_32BIT))
return true;
return false;
Expand Down
Loading