Skip to content

[flang][cuda] Relax the verifier for cuf.register_kernel op #112585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 17, 2024
Merged

[flang][cuda] Relax the verifier for cuf.register_kernel op #112585

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b2d4f9b
[flang][cuda] Relax the verifier for cuf.register_kernel op
clementval Oct 16, 2024
9487980
Looks at LLVMFuncOp
clementval Oct 16, 2024
b3dea7c
Do not check if binary
clementval Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions flang/lib/Optimizer/Dialect/CUF/CUFOps.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,12 +281,12 @@ mlir::LogicalResult cuf::RegisterKernelOp::verify() {

mlir::SymbolTable gpuSymTab(gpuMod);
auto func = gpuSymTab.lookup<mlir::gpu::GPUFuncOp>(getKernelName());
if (!func)
return emitOpError("device function not found");

if (!func.isKernel())
return emitOpError("only kernel gpu.func can be registered");

if (func) {
// Only check if the gpu.func is found. It might be converted to LLVMFuncOp
// already.
if (!func.isKernel())
return emitOpError("only kernel gpu.func can be registered");
}
return mlir::success();
}

Expand Down
15 changes: 0 additions & 15 deletions flang/test/Fir/cuf-invalid.fir
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,21 +143,6 @@ module attributes {gpu.container_module} {

// -----

module attributes {gpu.container_module} {
gpu.module @cuda_device_mod {
gpu.func @_QPsub_device1() {
gpu.return
}
}
llvm.func internal @__cudaFortranConstructor() {
// expected-error@+1{{'cuf.register_kernel' op device function not found}}
cuf.register_kernel @cuda_device_mod::@_QPsub_device2
llvm.return
}
}

// -----

module attributes {gpu.container_module} {
llvm.func internal @__cudaFortranConstructor() {
// expected-error@+1{{'cuf.register_kernel' op gpu module not found}}
Expand Down
Loading