[clang-include-cleaner] Fix -Wpessimizing-move warning introduced in 4cda28c1ada702a08f6960eb4c93919187c1d4d1

[bc-lee]

Failing log: https://lab.llvm.org/buildbot/#/builders/145/builds/2540

[bc-lee]

Original PR: #111375

[llvmbot]

@llvm/pr-subscribers-clang-tools-extra

Author: Byoungchan Lee (bc-lee)

Changes

Failing log: https://lab.llvm.org/buildbot/#/builders/145/builds/2540

---

Full diff: https://github.com/llvm/llvm-project/pull/112684.diff

1 Files Affected:

• (modified) clang-tools-extra/include-cleaner/tool/IncludeCleaner.cpp (+1-1)

diff --git a/clang-tools-extra/include-cleaner/tool/IncludeCleaner.cpp b/clang-tools-extra/include-cleaner/tool/IncludeCleaner.cpp
index 6bd9c40c70753c..f85dbc0e0c31f2 100644
--- a/clang-tools-extra/include-cleaner/tool/IncludeCleaner.cpp
+++ b/clang-tools-extra/include-cleaner/tool/IncludeCleaner.cpp
@@ -299,7 +299,7 @@ mapInputsToAbsPaths(clang::tooling::CompilationDatabase &CDB,
     if (auto Err = VFS->makeAbsolute(AbsPath)) {
       llvm::errs() << "Failed to get absolute path for " << Source << " : "
                    << Err.message() << '\n';
-      return std::move(llvm::errorCodeToError(Err));
+      return llvm::errorCodeToError(Err);
     }
     std::vector<clang::tooling::CompileCommand> Cmds =
         CDB.getCompileCommands(AbsPath);

[mikaelholmen]

Already fixed in 2954d1f

    [include-cleaner] Fix -Wpessimizing-move in IncludeCleaner.cpp (NFC)
    
    /llvm-project/clang-tools-extra/include-cleaner/tool/IncludeCleaner.cpp:302:14:
    error: moving a temporary object prevents copy elision [-Werror,-Wpessimizing-move]
          return std::move(llvm::errorCodeToError(Err));
                 ^
    /llvm-project/clang-tools-extra/include-cleaner/tool/IncludeCleaner.cpp:302:14: note: remove std::move call here
          return std::move(llvm::errorCodeToError(Err));
                 ^~~~~~~~~~                           ~
    1 error generated.