Skip to content

[lldb][test][NFC] Document DYLIB_NAME Makefile variable #112735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 19, 2024
Merged

[lldb][test][NFC] Document DYLIB_NAME Makefile variable #112735

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6da0d2a
[lldb][test][NFC] Document DYLIB_NAME Makefile variable
Michael137 Oct 17, 2024
00642f0
fixup! clarify platform-dependent nature of the dylib name
Michael137 Oct 18, 2024
1589360
fixup! add lib prefix
Michael137 Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions lldb/packages/Python/lldbsuite/test/make/Makefile.rules
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,13 @@
# the building of the a.out executable program. For example,
# DYLIB_ONLY := YES
#
# When specifying one of the DYLIB_*_SOURCES variables, DYLIB_NAME
# controls the name of the produced dylib. E.g., if set to "foo",
# the generated dylib will be called "foo.<platform-specific-extension>",
# which on Darwin will be "foo.dylib".
Copy link
Member

@bulbazord bulbazord Oct 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is interesting. LLDB makes an assumption that a module named foo will be turned onto libfoo.dylib on Darwin. See Platform::GetFullNameForDylib

Copy link
Member Author

@Michael137 Michael137 Oct 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! it was meant to be libfoo for the darwin example :)

Copy link
Collaborator

@labath labath Oct 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, the "lib" part is platform specific as well. Windows does not have that convention. Libraries (at least, those that aren't very obviously unixy in origin) don't have it:

llvm-project/lldb/packages/Python/lldbsuite/test/lldbplatformutil.py

Line 212 in 5a09ce9

def createPlatformContext():

Copy link
Member Author

@Michael137 Michael137 Oct 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, reworded to make it clear this is platform dependent (with an example of how it would look like on Darwin)

#
# DYLIB_NAME := foo
#
# Specifying FRAMEWORK and its variants has the effect of building a NeXT-style
# framework.
# FRAMEWORK := "Foo"
Expand Down
Loading