Skip to content

Conversation

@ldionne
Copy link
Member

@ldionne ldionne commented Oct 17, 2024

We don't use Appveyor to run Windows CI anymore (in fact I don't know if we ever did). Our full Windows CI setup is based on Github actions, so these files are effectively dead code.

We don't use Appveyor to run Windows CI anymore (in fact I don't know
if we ever did). Our full Windows CI setup is based on Github actions,
so these files are effectively dead code.
@ldionne ldionne requested review from EricWF and mstorsjo October 17, 2024 16:30
@ldionne ldionne requested a review from a team as a code owner October 17, 2024 16:30
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Oct 17, 2024
@llvmbot
Copy link
Member

llvmbot commented Oct 17, 2024

@llvm/pr-subscribers-libcxx

Author: Louis Dionne (ldionne)

Changes

We don't use Appveyor to run Windows CI anymore (in fact I don't know if we ever did). Our full Windows CI setup is based on Github actions, so these files are effectively dead code.


Full diff: https://github.com/llvm/llvm-project/pull/112744.diff

2 Files Affected:

  • (removed) libcxx/appveyor-reqs-install.cmd (-53)
  • (removed) libcxx/appveyor.yml (-71)
diff --git a/libcxx/appveyor-reqs-install.cmd b/libcxx/appveyor-reqs-install.cmd
deleted file mode 100644
index e3bd018dd3742e..00000000000000
--- a/libcxx/appveyor-reqs-install.cmd
+++ /dev/null
@@ -1,53 +0,0 @@
-@echo on
-
-if NOT EXIST C:\projects\deps (
-  mkdir C:\projects\deps
-)
-cd C:\projects\deps
-
-::###########################################################################
-:: Setup Compiler
-::###########################################################################
-if NOT EXIST llvm-installer.exe (
-  appveyor DownloadFile https://prereleases.llvm.org/win-snapshots/LLVM-9.0.0-r357435-win32.exe -FileName llvm-installer.exe
-)
-if "%CLANG_VERSION%"=="ToT" (
-    START /WAIT llvm-installer.exe /S /D=C:\"Program Files\LLVM"
-)
-if DEFINED CLANG_VERSION  @set PATH="C:\Program Files\LLVM\bin";%PATH%
-if DEFINED CLANG_VERSION  clang-cl -v
-
-if DEFINED MINGW_PATH rename "C:\Program Files\Git\usr\bin\sh.exe" "sh-ignored.exe"
-if DEFINED MINGW_PATH @set "PATH=%PATH:C:\Program Files (x86)\Git\bin=%"
-if DEFINED MINGW_PATH @set "PATH=%PATH%;%MINGW_PATH%"
-if DEFINED MINGW_PATH g++ -v
-
-::###########################################################################
-:: Install a recent CMake
-::###########################################################################
-if NOT EXIST cmake (
-  appveyor DownloadFile https://cmake.org/files/v3.7/cmake-3.7.2-win64-x64.zip -FileName cmake.zip
-  7z x cmake.zip -oC:\projects\deps > nul
-  move C:\projects\deps\cmake-* C:\projects\deps\cmake
-  rm cmake.zip
-)
-@set PATH=C:\projects\deps\cmake\bin;%PATH%
-cmake --version
-
-::###########################################################################
-:: Install Ninja
-::###########################################################################
-if NOT EXIST ninja (
-  appveyor DownloadFile https://github.com/ninja-build/ninja/releases/download/v1.6.0/ninja-win.zip -FileName ninja.zip
-  7z x ninja.zip -oC:\projects\deps\ninja > nul
-  rm ninja.zip
-)
-@set PATH=C:\projects\deps\ninja;%PATH%
-ninja --version
-
-::###########################################################################
-:: Setup the cached copy of LLVM
-::###########################################################################
-git clone --depth=1 http://llvm.org/git/llvm.git
-
-@echo off
diff --git a/libcxx/appveyor.yml b/libcxx/appveyor.yml
deleted file mode 100644
index 8a69cb9e7dde0e..00000000000000
--- a/libcxx/appveyor.yml
+++ /dev/null
@@ -1,71 +0,0 @@
-version: '{build}'
-
-shallow_clone: true
-
-build:
-  verbosity: detailed
-
-configuration:
-  - Debug
-
-environment:
-  matrix:
-    - APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2017
-      CMAKE_OPTIONS: -DCMAKE_C_COMPILER=clang-cl.exe -DCMAKE_CXX_COMPILER=clang-cl.exe
-      CLANG_VERSION: ToT
-      MSVC_SETUP_PATH: C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Auxiliary\Build\vcvarsall.bat
-      MSVC_SETUP_ARG: x86
-      GENERATOR: Ninja
-      MAKE_PROGRAM: ninja
-      APPVEYOR_SAVE_CACHE_ON_ERROR: true
-# TODO: Maybe re-enable this configuration? Do we want to support MSVC 2015's runtime?
-#    - APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2015
-#      MINGW_PATH: C:\mingw-w64\i686-6.3.0-posix-dwarf-rt_v5-rev1\mingw32\bin
-#      GENERATOR: MinGW Makefiles
-#      MAKE_PROGRAM: mingw32-make
-#      APPVEYOR_SAVE_CACHE_ON_ERROR: true
-
-install:
-  ############################################################################
-  # All external dependencies are installed in C:\projects\deps
-  ############################################################################
-  - call "%APPVEYOR_BUILD_FOLDER%\\appveyor-reqs-install.cmd"
-
-before_build:
-  - if DEFINED MSVC_SETUP_PATH call "%MSVC_SETUP_PATH%" %MSVC_SETUP_ARG%
-  - cd %APPVEYOR_BUILD_FOLDER%
-
-build_script:
-  - md C:\projects\build-libcxx
-  - cd C:\projects\build-libcxx
-  - echo %configuration%
-
-  #############################################################################
-  # Configuration Step
-  #############################################################################
-  - cmake -G "%GENERATOR%" %CMAKE_OPTIONS%
-    "-DCMAKE_BUILD_TYPE=%configuration%"
-    "-DLLVM_PATH=C:\projects\deps\llvm"
-    -DLLVM_LIT_ARGS="-v --show-xfail --show-unsupported"
-    %APPVEYOR_BUILD_FOLDER%
-
-  #############################################################################
-  # Build Step
-  #############################################################################
-  - "%MAKE_PROGRAM%"
-
-test_script:
-  - "%MAKE_PROGRAM% check-cxx"
-
-on_failure:
-  - appveyor PushArtifact CMakeFiles/CMakeOutput.log
-  - appveyor PushArtifact CMakeFiles/CMakeError.log
-
-artifacts:
-  - path: '_build/CMakeFiles/*.log'
-    name: logs
-
-cache:
- - C:\projects\deps\ninja
- - C:\projects\deps\cmake
- - C:\projects\deps\llvm-installer.exe

Copy link
Member

@mstorsjo mstorsjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Based on digging in git history, it seems like these were last changed when it seems they were in active use around 2019.

@ldionne ldionne merged commit 2cd10f5 into llvm:main Oct 17, 2024
63 of 65 checks passed
@ldionne ldionne deleted the review/remove-appveyor branch October 17, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants