Skip to content

[clang] Add covariance tests that make sure we return an error when return value is different in pointer / lvalue ref / rvalue ref #112853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 21, 2024
Merged

[clang] Add covariance tests that make sure we return an error when return value is different in pointer / lvalue ref / rvalue ref #112853

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b1ffbf6
[clang] Add covariance tests that make sure we return an error when r…
bricknerb Oct 21, 2024
b4221ce
[clang] Move the tests for https://cplusplus.github.io/CWG/issues/960…
bricknerb Oct 21, 2024
c07e53d
[clang] Update clang/www/cxx_dr_status.html for CWG 960.
bricknerb Oct 21, 2024
d76fc7a
[clang] Change style of cwg960 test expectations to be more consisten…
bricknerb Oct 21, 2024
181a972
[clang] Update cwg960 test to clang 3.0.
bricknerb Oct 21, 2024
7c798f9
[clang] Revert unrelated changes in clang/test/SemaCXX/virtual-overri…
bricknerb Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 24 additions & 4 deletions clang/test/SemaCXX/virtual-override.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ namespace T6 {
struct a { };

class A {
// Classes.
// Check cv-qualification.
virtual const a* const_vs_unqualified_class();
virtual a* unqualified_vs_const_class(); // expected-note{{overridden virtual function is here}}

Expand All @@ -102,13 +102,23 @@ class A {
virtual const volatile a* const_volatile_vs_unualified_class();
virtual a* unqualified_vs_const_volatile_class(); // expected-note{{overridden virtual function is here}}

// Non Classes.
// Check lvalue ref vs rvalue ref vs pointer.
virtual a& rvalue_ref();
virtual a&& lvalue_ref();
virtual a& rvalue_vs_lvalue_ref(); // expected-note{{overridden virtual function is here}}
virtual a&& lvalue_vs_rvalue_ref(); // expected-note{{overridden virtual function is here}}
virtual a& rvalue_ref_vs_pointer(); // expected-note{{overridden virtual function is here}}
virtual a* pointer_vs_rvalue_ref(); // expected-note{{overridden virtual function is here}}
virtual a&& lvalue_ref_vs_pointer(); // expected-note{{overridden virtual function is here}}
virtual a* pointer_vs_lvalue_ref(); // expected-note{{overridden virtual function is here}}

// Check non class.
virtual const int* const_vs_unqualified_non_class(); // expected-note{{overridden virtual function is here}}
virtual int* unqualified_vs_const_non_class(); // expected-note{{overridden virtual function is here}}
};

class B : A {
// Classes.
// Check cv-qualification.
a* const_vs_unqualified_class() override;
const a* unqualified_vs_const_class() override; // expected-error{{return type of virtual function 'unqualified_vs_const_class' is not covariant with the return type of the function it overrides (class type 'const a *' does not have the same cv-qualification as or less cv-qualification than class type 'a *')}}

Expand All @@ -127,7 +137,17 @@ class B : A {
a* const_volatile_vs_unualified_class() override;
const volatile a* unqualified_vs_const_volatile_class() override; // expected-error{{return type of virtual function 'unqualified_vs_const_volatile_class' is not covariant with the return type of the function it overrides (class type 'const volatile a *' does not have the same cv-qualification as or less cv-qualification than class type 'a *')}}

// Non Classes.
// Check lvalue ref vs rvalue ref vs pointer.
a& rvalue_ref() override;
a&& lvalue_ref() override;
a&& rvalue_vs_lvalue_ref() override; // expected-error{{virtual function 'rvalue_vs_lvalue_ref' has a different return type ('a &&') than the function it overrides (which has return type 'a &')}}
a& lvalue_vs_rvalue_ref() override; // expected-error{{virtual function 'lvalue_vs_rvalue_ref' has a different return type ('a &') than the function it overrides (which has return type 'a &&')}}
a* rvalue_ref_vs_pointer() override; // expected-error{{virtual function 'rvalue_ref_vs_pointer' has a different return type ('a *') than the function it overrides (which has return type 'a &')}}
a& pointer_vs_rvalue_ref() override; // expected-error{{virtual function 'pointer_vs_rvalue_ref' has a different return type ('a &') than the function it overrides (which has return type 'a *')}}
a* lvalue_ref_vs_pointer() override; // expected-error{{virtual function 'lvalue_ref_vs_pointer' has a different return type ('a *') than the function it overrides (which has return type 'a &&')}}
a&& pointer_vs_lvalue_ref() override; // expected-error{{virtual function 'pointer_vs_lvalue_ref' has a different return type ('a &&') than the function it overrides (which has return type 'a *')}}

// Check non class.
int* const_vs_unqualified_non_class() override; // expected-error{{virtual function 'const_vs_unqualified_non_class' has a different return type ('int *') than the function it overrides (which has return type 'const int *')}}
const int* unqualified_vs_const_non_class() override; // expected-error{{virtual function 'unqualified_vs_const_non_class' has a different return type ('const int *') than the function it overrides (which has return type 'int *')}}
};
Expand Down
Loading