Skip to content

Use std::move to avoid copy #113054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Use std::move to avoid copy #113054

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7605037
Use `std::move` to avoid redundant copy
abhishek-kaushik22 Oct 19, 2024
014565e
Use `std::move` to avoid copy
abhishek-kaushik22 Oct 19, 2024
c0e13d2
Update DecoderEmitter.cpp
abhishek-kaushik22 Oct 19, 2024
7c6848a
Update DecoderEmitter.cpp
abhishek-kaushik22 Oct 19, 2024
2ce9d2a
Update DecoderEmitter.cpp
abhishek-kaushik22 Oct 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions llvm/utils/TableGen/DecoderEmitter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1893,7 +1893,7 @@ OperandInfo getOpInfo(const Record *TypeRecord) {
bool HasCompleteDecoder =
HasCompleteDecoderBit ? HasCompleteDecoderBit->getValue() : true;

return OperandInfo(Decoder, HasCompleteDecoder);
return OperandInfo(std::move(Decoder), HasCompleteDecoder);
}

static void parseVarLenInstOperand(const Record &Def,
Expand Down Expand Up @@ -2024,7 +2024,7 @@ populateInstruction(const CodeGenTarget &Target, const Record &EncodingDef,
EncodingDef.getValueAsBit("hasCompleteDecoder");
InsnOperands.push_back(
OperandInfo(std::string(InstDecoder), HasCompleteInstDecoder));
Operands[Opc] = InsnOperands;
Operands[Opc] = std::move(InsnOperands);
return Bits.getNumBits();
}

Expand Down Expand Up @@ -2059,7 +2059,7 @@ populateInstruction(const CodeGenTarget &Target, const Record &EncodingDef,
MyName = Op.Name;

TiedNames[MyName] = TiedName;
TiedNames[TiedName] = MyName;
TiedNames[TiedName] = std::move(MyName);
}
}
}
Expand Down Expand Up @@ -2112,7 +2112,7 @@ populateInstruction(const CodeGenTarget &Target, const Record &EncodingDef,

addOneOperandFields(EncodingDef, Bits, TiedNames, SubOpName,
SubOpInfo);
InsnOperands.push_back(SubOpInfo);
InsnOperands.push_back(std::move(SubOpInfo));
}
continue;
}
Expand Down Expand Up @@ -2143,7 +2143,7 @@ populateInstruction(const CodeGenTarget &Target, const Record &EncodingDef,
// instruction! (This is a longstanding bug, which will be addressed in an
// upcoming change.)
if (OpInfo.numFields() > 0)
InsnOperands.push_back(OpInfo);
InsnOperands.push_back(std::move(OpInfo));
}
}
Operands[Opc] = InsnOperands;
Expand Down
Loading