Skip to content

[mlir] Avoid repeated map lookups (NFC) #113122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2024
Merged

[mlir] Avoid repeated map lookups (NFC) #113122

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions mlir/lib/Dialect/SparseTensor/IR/SparseTensorDialect.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1142,16 +1142,18 @@ bool mlir::sparse_tensor::isBlockSparsity(AffineMap dimToLvl) {
auto pos = dimOp.getPosition();
if (binOp.getKind() == AffineExprKind::FloorDiv) {
// Expect only one floordiv for each dimension.
if (coeffientMap.find(pos) != coeffientMap.end())
auto [it, inserted] = coeffientMap.try_emplace(pos);
if (!inserted)
return false;
// Record coefficient of the floordiv.
coeffientMap[pos] = conOp.getValue();
it->second = conOp.getValue();
} else if (binOp.getKind() == AffineExprKind::Mod) {
// Expect floordiv before mod.
if (coeffientMap.find(pos) == coeffientMap.end())
auto it = coeffientMap.find(pos);
if (it == coeffientMap.end())
return false;
// Expect mod to have the same coefficient as floordiv.
if (conOp.getValue() != coeffientMap[pos])
if (conOp.getValue() != it->second)
return false;
hasBlock = true;
} else {
Expand Down
Loading