Skip to content

EarlyCSE: refactor getOrCreateResult (NFC) #113339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
artagnon merged 2 commits into from
Nov 5, 2024
+18 −25
Merged

EarlyCSE: refactor getOrCreateResult (NFC) #113339

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1bf8fe9
EarlyCSE: create casts on type-mismatch
artagnon Oct 22, 2024
fa6390e
EarlyCSE: preserve TODO
artagnon Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 18 additions & 25 deletions llvm/lib/Transforms/Scalar/EarlyCSE.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -964,33 +964,26 @@ class EarlyCSE {
bool overridingStores(const ParseMemoryInst &Earlier,
const ParseMemoryInst &Later);

Value *getOrCreateResult(Value *Inst, Type *ExpectedType) const {
// TODO: We could insert relevant casts on type mismatch here.
if (auto *LI = dyn_cast<LoadInst>(Inst))
return LI->getType() == ExpectedType ? LI : nullptr;
if (auto *SI = dyn_cast<StoreInst>(Inst)) {
Value *V = SI->getValueOperand();
return V->getType() == ExpectedType ? V : nullptr;
Value *getOrCreateResult(Instruction *Inst, Type *ExpectedType) const {
// TODO: We could insert relevant casts on type mismatch.
// The load or the store's first operand.
Value *V;
if (auto *II = dyn_cast<IntrinsicInst>(Inst)) {
switch (II->getIntrinsicID()) {
case Intrinsic::masked_load:
V = II;
break;
case Intrinsic::masked_store:
V = II->getOperand(0);
break;
default:
return TTI.getOrCreateResultFromMemIntrinsic(II, ExpectedType);
}
} else {
V = isa<LoadInst>(Inst) ? Inst : cast<StoreInst>(Inst)->getValueOperand();
}
assert(isa<IntrinsicInst>(Inst) && "Instruction not supported");
auto *II = cast<IntrinsicInst>(Inst);
if (isHandledNonTargetIntrinsic(II->getIntrinsicID()))
return getOrCreateResultNonTargetMemIntrinsic(II, ExpectedType);
return TTI.getOrCreateResultFromMemIntrinsic(II, ExpectedType);
}

Value *getOrCreateResultNonTargetMemIntrinsic(IntrinsicInst *II,
Type *ExpectedType) const {
// TODO: We could insert relevant casts on type mismatch here.
switch (II->getIntrinsicID()) {
case Intrinsic::masked_load:
return II->getType() == ExpectedType ? II : nullptr;
case Intrinsic::masked_store: {
Value *V = II->getOperand(0);
return V->getType() == ExpectedType ? V : nullptr;
}
}
return nullptr;
return V->getType() == ExpectedType ? V : nullptr;
}

/// Return true if the instruction is known to only operate on memory
Expand Down
Loading