Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion llvm/docs/CodeReview.rst
Original file line number Diff line number Diff line change
Expand Up @@ -142,12 +142,18 @@ from specific performance tests), please explain as many of these up front as
possible. This allows the patch author and reviewers to make the most efficient
use of their time.

.. _lgtm_how_a_patch_is_accepted:

LGTM - How a Patch Is Accepted
------------------------------

A patch is approved to be committed when a reviewer accepts it, and this is
almost always associated with a message containing the text "LGTM" (which
stands for Looks Good To Me). Only approval from a single reviewer is required.
stands for Looks Good To Me).

Only approval from a single reviewer is required, unless the pull request
has required reviewers. In which case, you must have approval from all of those
reviewers.

When providing an unqualified LGTM (approval to commit), it is the
responsibility of the reviewer to have reviewed all of the discussion and
Expand Down
8 changes: 7 additions & 1 deletion llvm/docs/GitHub.rst
Original file line number Diff line number Diff line change
Expand Up @@ -138,10 +138,16 @@ you won't encounter merge conflicts when landing the PR.
collaborating with others on a single branch, be careful how and when you push
changes. ``--force-with-lease`` may be useful in this situation.

Approvals
---------

Before merging a PR you must have the required approvals. See
:ref:`lgtm_how_a_patch_is_accepted` for more details.

Landing your change
-------------------

When your PR has been accepted you can merge your changes.
When your PR has been approved you can merge your changes.

If you do not have write permissions for the repository, the merge button in
GitHub's web interface will be disabled. If this is the case, continue following
Expand Down
Loading