Skip to content

[ORC-RT] Initial check-in for a new, top-level ORC runtime project. #113499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

[ORC-RT] Initial check-in for a new, top-level ORC runtime project. #113499

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
fb7698d
[ORC-RT] Initial check-in for a new, top-level ORC runtime project.
lhames Oct 23, 2024
f801afb
clang-format
lhames Oct 24, 2024
6011619
Simplify CMake files, add install support.
lhames Oct 27, 2024
81dc0e4
Use '//' style comments.
lhames Oct 28, 2024
7106b9d
Add missing copyright header.
lhames Oct 28, 2024
db27097
Use 'install (DIRECTORY...' instead of file sets.
lhames Oct 28, 2024
b0eb599
Add missing copyright header.
lhames Oct 28, 2024
400d2fc
Add license and documentation.
lhames Oct 30, 2024
4a03938
Remove CREDITS.TXT
lhames Oct 31, 2024
e872a8c
Remove legacy license text.
lhames Oct 31, 2024
bb5fb11
Fix default for ORC_RT_INCLUDE_DOCS option.
lhames Oct 31, 2024
267fd01
Switch docs from reStructuredText to markdown.
lhames Oct 31, 2024
327a64a
Silence python linter.
lhames Oct 31, 2024
0a25634
Python linter is persnickety.
lhames Oct 31, 2024
b348769
Update orc-rt/docs/Building-orc-rt.md
lhames Mar 3, 2025
7a3a185
[ORC-RT][docs] Fix copyright year and project name capitalization.
Mar 3, 2025
b804b1f
[ORC-RT] Update sphinx version.
lhames Mar 4, 2025
c57f7ce
[ORC-RT] Add TODO to switch to filesets when we can.
lhames Mar 4, 2025
e31c343
Specify COMPONENT for headers, use 'install(TARGETS ...' rather than
lhames May 14, 2025
e512c16
Rename project LibOrcRT -> OrcRT.
lhames May 14, 2025
91e73b1
Remove unnecessary target_include_directories(...)
lhames May 14, 2025
ea1955d
Adding ways to find utils during a RT build
jaredwy Aug 1, 2025
cab25e9
Merge branch 'main' into new-new-orc-rt
lhames Aug 4, 2025
3d624db
Update lit.cfg.py to fix formatting.
lhames Aug 5, 2025
124d7e4
Merge branch 'main' into new-new-orc-rt
lhames Aug 5, 2025
6957220
Merge branch 'main' into new-new-orc-rt
lhames Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion orc-rt/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ set(LLVM_COMMON_CMAKE_UTILS ${CMAKE_CURRENT_SOURCE_DIR}/../cmake)
include(${LLVM_COMMON_CMAKE_UTILS}/Modules/CMakePolicy.cmake
NO_POLICY_SCOPE)

project(LibOrcRT LANGUAGES C CXX ASM)
project(OrcRT LANGUAGES C CXX ASM)

include(GNUInstallDirs)

Expand Down
4 changes: 2 additions & 2 deletions orc-rt/include/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ target_include_directories(orc-rt-headers INTERFACE
set_property(TARGET orc-rt-headers
PROPERTY PUBLIC_HEADER ${ORC_RT_HEADERS}
)
install(DIRECTORY ./
install(TARGETS orc-rt-headers
DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}/
FILES_MATCHING PATTERN "*.h"
COMPONENT OrcRT_Development
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't install headers unless you use FILE_SET (and then you need to install the file set).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought that the PUBLIC_HEADER property set on orc-rt-headers above would cause install(TARGET ...) to install the headers:

set_property(TARGET orc-rt-headers
    PROPERTY PUBLIC_HEADER ${ORC_RT_HEADERS}
)

If I configure and build on linux with

% cmake -GNinja -DCMAKE_INSTALL_PREFIX=/path/to/install -DCMAKE_BUILD_TYPE=Debug -DLLVM_ENABLE_RUNTIMES=orc-rt /path/to/llvm-project/runtimes
% ninja install

I see the headers in the expected location. Am I relying on non-portable behavior here though?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

D'oh! Yes, PUBLIC_HEADER should work; I had forgotten about this mechanism. I believe it flattens the hierarchy, but maybe that's not the case.

)
1 change: 0 additions & 1 deletion orc-rt/tools/orc-executor/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
add_executable(orc-executor orc-executor.cpp)
target_link_libraries(orc-executor PRIVATE orc-rt-executor)
target_include_directories(orc-executor PRIVATE ../../include)