Skip to content

[Tooling/Inclusion] Add binary search related std::ranges symbols to the mapping. #113796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 30, 2024
Merged

[Tooling/Inclusion] Add binary search related std::ranges symbols to the mapping. #113796

Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
aa9e5c5
add Binary search operations (on sorted ranges)
c8ef Oct 27, 2024
1b538cb
Update StdSpecialSymbolMap.inc
c8ef Oct 29, 2024
08b8fa1
Update StdSymbolMap.inc
c8ef Oct 29, 2024
8c44a69
Merge branch 'main' into tidy
c8ef Oct 29, 2024
956a711
Update StdSpecialSymbolMap.inc
c8ef Oct 29, 2024
0319249
Merge branch 'main' into tidy
c8ef Oct 29, 2024
c7c2f8f
Update StdSpecialSymbolMap.inc
c8ef Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions clang/lib/Tooling/Inclusions/Stdlib/StdSpecialSymbolMap.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,6 +411,11 @@ SYMBOL(_27, std::placeholders::, <functional>)
SYMBOL(_28, std::placeholders::, <functional>)
SYMBOL(_29, std::placeholders::, <functional>)

SYMBOL(binary_search, std::ranges::, <algorithm>)
Copy link
Member

@kadircet kadircet Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you move this next to

llvm-project/clang/lib/Tooling/Inclusions/Stdlib/StdSpecialSymbolMap.inc

Lines 363 to 369 in 2de1fc8

// Symbols missing from the generated symbol map as reported by users.
// Remove when the generator starts producing them.
SYMBOL(make_any, std::, <any>)
SYMBOL(any_cast, std::, <any>)
SYMBOL(div, std::, <cstdlib>)
SYMBOL(abort, std::, <cstdlib>)
?

Copy link
Contributor Author

@c8ef c8ef Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

SYMBOL(equal_range, std::ranges::, <algorithm>)
SYMBOL(lower_bound, std::ranges::, <algorithm>)
SYMBOL(upper_bound, std::ranges::, <algorithm>)

// Macros
SYMBOL(NULL, None, <cstddef>)
SYMBOL(NULL, None, <stddef.h>)
Expand Down
Loading