[CodeGen] Add comment to MachineBasicBlock::instrs method. #113868
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please review the PR? I should have triggered Evan Cheng as maintainer of |
|
LGTM, thanks |
dsandersllvm
approved these changes
Oct 28, 2024
ivafanas
force-pushed
the
add-comment-to-instrs-mbb-method
branch
from
4f24a02 to
379ff4a
Compare
|
ping :) Hi @dsandersllvm , I do not have commit access. Could you please merge it if it is still useful? |
|
ping :) |
|
Closing MR due to no response for a long time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add comment that
MachineBasicBlock::instrsmethod returns range that iterates over bundled instructions unlikebegin/endmethods returns range over bundled instructions.#113676 (review)