Nominate Sirraide for AST visitors and Sema #114092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sirraide has been actively reviewing Sema code for a while now and definitely has the expertise to help maintain that section of the compiler. Further, he has been refactoring AST visitors to try to reduce the compile time overhead associated with them and would be a good resource for keeping an eye on that part of the code base too.
Member
|
@llvm/pr-subscribers-clang Author: Aaron Ballman (AaronBallman) ChangesSirraide has been actively reviewing Sema code for a while now and definitely has the expertise to help maintain that section of the compiler. Further, he has been refactoring AST visitors to try to reduce the compile time overhead associated with them and would be a good resource for keeping an eye on that part of the code base too. Full diff: https://github.com/llvm/llvm-project/pull/114092.diff 1 Files Affected:
diff --git a/clang/Maintainers.rst b/clang/Maintainers.rst
index 39f46457e676a8..993a7a1252a567 100644
--- a/clang/Maintainers.rst
+++ b/clang/Maintainers.rst
@@ -33,6 +33,12 @@ AST matchers
| aaron\@aaronballman.com (email), aaron.ballman (Phabricator), AaronBallman (GitHub), AaronBallman (Discourse), aaronballman (Discord), AaronBallman (IRC)
+AST Visitors
+~~~~~~~~~~~~
+| Sirraide
+| aeternalmail\@gmail.com (email), Sirraide (GitHub), Ætérnal (Discord), Sirraide (Discourse)
+
+
Clang LLVM IR generation
~~~~~~~~~~~~~~~~~~~~~~~~
| John McCall
@@ -57,6 +63,12 @@ Analysis & CFG
| sgatev\@google.com (email), sgatev (Phabricator), sgatev (GitHub)
+Sema
+~~~~
+| Sirraide
+| aeternalmail\@gmail.com (email), Sirraide (GitHub), Ætérnal (Discord), Sirraide (Discourse)
+
+
Experimental new constant interpreter
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| Timm Bäder
|
erichkeane
approved these changes
Oct 29, 2024
Sirraide
approved these changes
Oct 29, 2024
Member
Sirraide
left a comment
Sirraide
left a comment
There was a problem hiding this comment.
Thanks for the nomination. I’d be happy to continue helping out w/ maintaining Clang!
NoumanAmir657
pushed a commit
to NoumanAmir657/llvm-project
that referenced
this pull request
Nov 4, 2024
Sirraide has been actively reviewing Sema code for a while now and definitely has the expertise to help maintain that section of the compiler. Further, he has been refactoring AST visitors to try to reduce the compile time overhead associated with them and would be a good resource for keeping an eye on that part of the code base too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sirraide has been actively reviewing Sema code for a while now and definitely has the expertise to help maintain that section of the compiler. Further, he has been refactoring AST visitors to try to reduce the compile time overhead associated with them and would be a good resource for keeping an eye on that part of the code base too.