Skip to content

[MLIR] support dynamic indexing in VectorEmulateNarrowTypes #114169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Nov 5, 2024
Merged

[MLIR] support dynamic indexing in VectorEmulateNarrowTypes #114169

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
2effa6a
Implement VectorLoadOp
lialan Oct 29, 2024
2580b46
Update tests
lialan Oct 30, 2024
0b9bdce
fix bugs
lialan Oct 30, 2024
a9d7260
Refactor and fixes
lialan Nov 1, 2024
b777a60
updates
lialan Nov 1, 2024
fc29242
update according to comments
lialan Nov 4, 2024
2b86a23
another update to resolve comments
lialan Nov 4, 2024
8225f72
Update mlir/lib/Dialect/Vector/Transforms/VectorEmulateNarrowType.cpp
lialan Nov 4, 2024
ce75839
Update mlir/lib/Dialect/Vector/Transforms/VectorEmulateNarrowType.cpp
lialan Nov 4, 2024
1c6f3c0
Update mlir/lib/Dialect/Vector/Transforms/VectorEmulateNarrowType.cpp
lialan Nov 4, 2024
74840ce
Update mlir/lib/Dialect/Vector/Transforms/VectorEmulateNarrowType.cpp
lialan Nov 4, 2024
80c313b
updates
lialan Nov 4, 2024
db1c38e
update test file
lialan Nov 4, 2024
71583fb
update tests
lialan Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions mlir/lib/Dialect/Vector/Transforms/VectorEmulateNarrowType.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,9 +133,9 @@ static FailureOr<Operation *> getCompressedMaskOp(OpBuilder &rewriter,
static Value extractSubvectorFrom(RewriterBase &rewriter, Location loc,
VectorType extractType, Value source,
int64_t frontOffset, int64_t subvecSize) {
auto vectorType = dyn_cast<VectorType>(source.getType());
assert(vectorType && vectorType.getRank() == 1 &&
extractType.getRank() == 1 &&
auto vectorType = cast<VectorType>(source.getType());
assert((vectorType.getRank() == 1 &&
extractType.getRank() == 1) &&
"expected 1-D source and destination types");
auto offsets = rewriter.getI64ArrayAttr({frontOffset});
auto sizes = rewriter.getI64ArrayAttr({subvecSize});
Expand Down
Loading